Closed Bug 440733 Opened 12 years ago Closed 12 years ago

Build XForms with static CRT on windows

Categories

(Core Graveyard :: XForms, defect)

x86
Windows Vista
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: imphil, Assigned: imphil)

Details

Attachments

(1 file, 2 obsolete files)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; de; rv:1.9) Gecko/2008052906 Firefox/3.0
Build Identifier: ff3.0

Currently, XForms trunk builds on Windows done with MSVC2005 or 2008 build a xforms.dll which depends on msvcr80.dll or msvcr90.dll. This DLL (the c runtime library) is not distributed with official Firefox builds and not available on all target systems either. Mozilla does their Firefox builds using a custom CRT including jemalloc (according to ted on IRC #developers). ted also recommended using USE_STATIC_LIBS=1 for all extensions, which statically links the runtime environment into the DLL.
See http://developer.mozilla.org/en/docs/USE_STATIC_LIBS for details.
Doing that gives us a DLL which works on all supported Windows versions, even those where that file is not available.

This was not a problem with 1.8 branch builds, as they are done using VS6, and the corresponding runtime library (msvcrt.dll) is available on all supported Windows versions by default.

Reproducible: Always
Attachment #325981 - Attachment is patch: true
Attachment #325981 - Attachment mime type: application/octet-stream → text/plain
Attached patch v2 (obsolete) — Splinter Review
Thissets USE_STATIC_LIBS for schema-validation, too.
Attachment #325981 - Attachment is obsolete: true
Attachment #326123 - Flags: review?(aaronr)
Attachment #325981 - Flags: review?(aaronr)
Comment on attachment 326123 [details] [diff] [review]
v2

Please add the same comment to the schema-validation makefile -> "required for Windows builds with..."

with that, r=me
Attachment #326123 - Flags: review?(aaronr) → review+
r+ by aaronr (i'm unable to copy the r+ flag)
Attachment #326123 - Attachment is obsolete: true
Attachment #333619 - Flags: review?
Attachment #333619 - Flags: review? → review?(Olli.Pettay)
Assignee: nobody → mail
Status: UNCONFIRMED → NEW
Ever confirmed: true
Comment on attachment 333619 [details] [diff] [review]
add comment as requested by Aaron

Seems to work on Linux/1.9-Branch
Attachment #333619 - Flags: review?(Olli.Pettay) → review+
Checked into cvs trunk for philipp.  Not needed for 1.8 branch.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.