44082 - Crash in nsExternalHelperAppService::Init()

Status: VERIFIED FIXED

(SeaMonkey :: General, defect, P3)

Description

[Johnny Stenback (:jst)]

I just crashed on a null pointer reference in nsExternalHelperAppService::Init()
while playing around with form submission in a local file in viewer, this patch
fixes the crash:

Index: uriloader/exthandler/nsExternalHelperAppService.cpp
===================================================================
RCS file: /cvsroot/mozilla/uriloader/exthandler/nsExternalHelperAppService.cpp,v
retrieving revision 1.13
diff -u -r1.13 nsExternalHelperAppService.cpp
--- nsExternalHelperAppService.cpp      2000/06/24 01:55:40     1.13
+++ nsExternalHelperAppService.cpp      2000/06/28 15:47:14
@@ -81,6 +81,8 @@
   nsCOMPtr<nsIFileSpec> mimeTypesFile;
   rv = locator->GetFileLocation(nsSpecialFileSpec::App_UsersMimeTypes50,
                                 getter_AddRefs(mimeTypesFile));
+  NS_ENSURE_SUCCESS(rv, rv);
+
   nsXPIDLCString url;
   rv = mimeTypesFile->GetURLString(getter_Copies(url));
   NS_ENSURE_SUCCESS(rv, rv);

(locator->GetFileLocation() failed so mimeTypesFile was null.)

Comment 1

[Scott MacGregor]

Hmmm I don't understand how we could fail to find this file in your profile.
That's a bit alarming.

But regardless I should be checking against failure in this case. Thanks for the
patch.

Nominating for beta2 so i can check in the fix for this crasher.

Comment 2

[Scott MacGregor]

just waiting on a nsbeta2+ to check in the failure check to prevent the crash.

Comment 3

[Jay Patel [:jay]]

Putting on [nsbeta2+] radar for beta2 fix. 

Comment 4

[Scott MacGregor]

fixed.

Comment 5

[Doron Rosenberg (IBM)]

jst - can you verify this fixed?

Comment 6

[Johnny Stenback (:jst)]

Verified.