440856 - Should the searchlogoform's orange search-arrow image have an ALT attribute?

Status: VERIFIED FIXED

(support.mozilla.org :: General, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

For accessibility reasons, I think the <div> "searchlogoform"'s orange search-arrow image should probably have at least an ALT attribute -- though I'm not sure; it might be enough that it's named.

cc:ing Marco -- thoughts?

Comment 1

[Marco Zehe (:MarcoZ)]

(In reply to comment #0)
> For accessibility reasons, I think the <div> "searchlogoform"'s orange
> search-arrow image should probably have at least an ALT attribute -- though I'm
> not sure; it might be enough that it's named.

No, it should definitely expose something more useful. Right now, the input has the following attributes:

id=searchsubmit
name=sa
type=submit
value= 

Since there's no value present, I'm getting "sa" as the button's label, which is not pretty. :-)

So either give the input a value, or give the associated image an alt attribute.

One other thing I noticed: Neither of the textboxes has a proper label. I mean, visually there's text that indicates what the textbox is for, but there is no HTML:label association with these textboxes.

On amo, for example, these search textboxes all have a proper label.

Comment 2

[David Tenser [:djst]]

We should definitely add alt="Search" or similar to that image.

Marco, the other things sound like stuff we should definitely fix on SUMO. Could you file bugs for that please? Thanks!

Comment 3

[Brian Krausz]

Will stick in an alt attr, as well as look into better labeling for the searchbox.

Comment 4

[Brian Krausz]

Added alt and title, r17263.

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

Is this fix localizable?

I can verify that ALT="Search" and TITLE="Search" are present.

Marco, could you also verify that this fix is fine on http://support-stage.mozilla.org/en-US/kb/?  (login=support, password=stage; these aren't private, they're just to prevent bots from archiving the staging site).  Thanks!

Comment 6

[Brian Krausz]

Already localized...see http://support-stage.mozilla.org/es/kb/

Comment 7

[Marco Zehe (:MarcoZ)]

This works just fine, thanks!

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED; thanks to both Marco and Brian (I should've checked another locale, my bad!)