Should the searchlogoform's orange search-arrow image have an ALT attribute?

VERIFIED FIXED in 0.7

Status

support.mozilla.org
General
VERIFIED FIXED
10 years ago
8 years ago

People

(Reporter: stephend, Assigned: Brian Krausz)

Tracking

({access})

unspecified
access

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: sumo_only theme, URL)

(Reporter)

Description

10 years ago
For accessibility reasons, I think the <div> "searchlogoform"'s orange search-arrow image should probably have at least an ALT attribute -- though I'm not sure; it might be enough that it's named.

cc:ing Marco -- thoughts?

Comment 1

10 years ago
(In reply to comment #0)
> For accessibility reasons, I think the <div> "searchlogoform"'s orange
> search-arrow image should probably have at least an ALT attribute -- though I'm
> not sure; it might be enough that it's named.

No, it should definitely expose something more useful. Right now, the input has the following attributes:

id=searchsubmit
name=sa
type=submit
value= 

Since there's no value present, I'm getting "sa" as the button's label, which is not pretty. :-)

So either give the input a value, or give the associated image an alt attribute.

One other thing I noticed: Neither of the textboxes has a proper label. I mean, visually there's text that indicates what the textbox is for, but there is no HTML:label association with these textboxes.

On amo, for example, these search textboxes all have a proper label.
(Reporter)

Updated

10 years ago
Keywords: access

Comment 2

10 years ago
We should definitely add alt="Search" or similar to that image.

Marco, the other things sound like stuff we should definitely fix on SUMO. Could you file bugs for that please? Thanks!

Updated

10 years ago
Target Milestone: 1.1 → 0.7
(Assignee)

Comment 3

10 years ago
Will stick in an alt attr, as well as look into better labeling for the searchbox.
Assignee: nobody → bkrausz
(Assignee)

Comment 4

10 years ago
Added alt and title, r17263.
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
(Reporter)

Comment 5

10 years ago
Is this fix localizable?

I can verify that ALT="Search" and TITLE="Search" are present.

Marco, could you also verify that this fix is fine on http://support-stage.mozilla.org/en-US/kb/?  (login=support, password=stage; these aren't private, they're just to prevent bots from archiving the staging site).  Thanks!
(Assignee)

Comment 6

10 years ago
Already localized...see http://support-stage.mozilla.org/es/kb/

Comment 7

10 years ago
This works just fine, thanks!
(Reporter)

Comment 8

10 years ago
Verified FIXED; thanks to both Marco and Brian (I should've checked another locale, my bad!)
Status: RESOLVED → VERIFIED

Updated

8 years ago
Whiteboard: sumo_only theme
You need to log in before you can comment on or make changes to this bug.