The paragraph under the "Hilfe" heading has a language attribute of "English".

VERIFIED FIXED in 3.4.5

Status

addons.mozilla.org Graveyard
Localization
--
major
VERIFIED FIXED
10 years ago
2 years ago

People

(Reporter: MarcoZ, Assigned: wenzel)

Tracking

({access})

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

10 years ago
On this add-on's page (and possibly all others that display the "Help" section), the sentence "Unterstützung für diese Erweiterung gibt der Entwickler unter ..." is marked up with a lang attribute that specifies "en-US" in its value. The rest of the page is fine. This lang attribute causes screen readers that support language switching to read this German sentence in English, making it incomprehensible.
(Assignee)

Comment 1

10 years ago
Thank you for pointing this out. I will submit a patch shortly.
Assignee: nobody → fwenzel
Target Milestone: --- → 3.4.5
(Assignee)

Comment 2

10 years ago
Created attachment 326323 [details] [diff] [review]
Remove lang attribute from support email paragraph

I removed the "lang" attribute from the paragraph, as the text is localized to the current page language and not dynamically localized by the developer.
Attachment #326323 - Flags: review?(clouserw)

Updated

10 years ago
Attachment #326323 - Flags: review?(clouserw) → review+
(Assignee)

Comment 3

10 years ago
Fixed in trunk, r16206. Thanks!
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Keywords: push-needed
Resolution: --- → FIXED
Production:         <h4 id="support">Hilfe</h4>
                <p  lang="en-US" dir="ltr" >

Preview (staging): <h4 id="support">Hilfe</h4>

Verified FIXED using https://preview.addons.mozilla.org/de/firefox/addon/5081
Status: RESOLVED → VERIFIED
3.4.5 was pushed on Friday.
Keywords: push-needed
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.