441034 - Unfocused <select> arrow-button has transparent background

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect)

Description

[Niro]

Attachment: testcase

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1a1pre) Gecko/2008062103 Minefield/3.1a1pre

On unfocused <select> control, the arrow-button has transparent background.
The color of the arrow is black. Therefore, on <select> with black background, the arrow-button will be invisible. 

The bug occurs on Windows Vista theme only. Switching to "Windows Classic" will make the arrow-button visible.

Comment 1

[Niro]

Attachment: screenshot

Comment 2

[Tomer Cohen :tomer]

I've talked with Nir, and he know about some real-world websites which can demonstrate this issue. Basically, every website with a black background theme and a <select> on the page is affected, for example this online forum (please look at the bottom of the page): http://forums.hacking.org.il/viewforum.php?f=1

Comment 3

[Kai Liu]

Attachment: fall back to old style if there's author styling

We should fall back to the old dropmarker style if the control has author-specified styling.  Not only is there the issue of transparency, but the new dropmarker style does not work well with anything other than native borders, and native borders are dropped if there is author styling.

Drop-down lists in XUL are currently rendered in a button-like style in Vista, so this is not applicable there.

I wonder if bug 434435 is a dupe of this; the reporter of that bug never posted a screenshot, so it's impossible to tell.

Comment 4

[Kai Liu]

Attachment: after patch

Comment 5

[Dão Gottwald [:dao]]

http://hg.mozilla.org/index.cgi/mozilla-central/rev/fe1683a02b0c

Comment 7

[Kai Liu]

Comment on attachment 326139 [details] [diff] [review]
fall back to old style if there's author styling

Requesting 1.9.0.2 approval: very low-risk patch to fix an accessibility problem.

Comment 8

[Samuel Sidler (old account; do not CC)]

Can we get an automated test for this before landing on 1.9?

Comment 9

[Kai Liu]

(In reply to comment #8)
> Can we get an automated test for this before landing on 1.9?
> 

I don't see how that could be done.  This is really a Vista theme issue, and as with all theme issues, there really isn't a way to test for this.  A check-if-equal refest won't work here, nor would a check-if-not-equal reftest (since the CSS needed to trigger the behavior would produce a difference in rendering anyway).

Comment 10

[Boris Zbarsky [:bzbarsky]]

Couldn't you assert that applying that author style is not the same as applying that style as UA style, but _is_ the same as applying it as UA style and using "-moz-appearance: none"?

Comment 11

[Kai Liu]

(In reply to comment #10)
> Couldn't you assert that applying that author style is not the same as applying
> that style as UA style, but _is_ the same as applying it as UA style and using
> "-moz-appearance: none"?
> 

That's a good idea.  But are we able to load agent and user sheets from a reftest?  I don't think that the stylesheet service is available to reftests, is it?

Comment 12

[Boris Zbarsky [:bzbarsky]]

As I recall, you can now run chrome reftests, no?

Comment 13

[Samuel Sidler (old account; do not CC)]

Comment on attachment 326139 [details] [diff] [review]
fall back to old style if there's author styling

Pushing approval out to 1.9.0.3.

Comment 14

[Samuel Sidler (old account; do not CC)]

Comment on attachment 326139 [details] [diff] [review]
fall back to old style if there's author styling

We're opting not to take this in a maintenance release.

But it should still get tests landed...