Closed
Bug 441059
Opened 16 years ago
Closed 16 years ago
nsDOMString.h is safe for non-internal API
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.9.1a1
People
(Reporter: WeirdAl, Assigned: WeirdAl)
References
()
Details
Attachments
(1 file, 1 obsolete file)
|
355 bytes,
patch
|
sicking
:
review+
sicking
:
superreview+
|
Details | Diff | Splinter Review |
A quick glance at nsDOMString.h shows it only defines two static functions. Reading them and nsStringAPI.h, I see no reason why we couldn't refer to nsStringAPI.h ifndef MOZILLA_INTERNAL_API.
Flags: wanted1.9.1?
|
Assignee | |
Comment 1•16 years ago
|
||
Assignee: nobody → ajvincent
Status: NEW → ASSIGNED
Attachment #326125 -
Flags: superreview?(jonas)
Attachment #326125 -
Flags: review?(jonas)
(In reply to comment #1) You want nsStringGlue.h
|
|
Assignee | |
Comment 3•16 years ago
|
||
Hm, thank you. I didn't know about that one.
Attachment #326125 -
Attachment is obsolete: true
Attachment #326148 -
Flags: superreview?(jonas)
Attachment #326148 -
Flags: review?(jonas)
Attachment #326125 -
Flags: superreview?(jonas)
Attachment #326125 -
Flags: review?(jonas)
Attachment #326148 -
Flags: superreview?(jonas)
Attachment #326148 -
Flags: superreview+
Attachment #326148 -
Flags: review?(jonas)
Attachment #326148 -
Flags: review+
|
||
Comment 4•16 years ago
|
||
Not wanted1.9.1, but feel free to land the patch etc.
Flags: wanted1.9.1? → wanted1.9.1-
|
|
Assignee | |
Updated•16 years ago
|
Keywords: checkin-needed
|
||
Comment 5•16 years ago
|
||
Pushed in 15857:0b2b1261afe9.
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1a1
Version: unspecified → Trunk
You need to log in
before you can comment on or make changes to this bug.
Description
•