441063 - image in default chrome with id safebrowsing-urlbar-icon is defunct

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect)

Description

[Jez]

There is an image node in the default FF3 chrome with ID safebrowsing-urlbar-icon, as part of the address bar, that appears to be defunct (it was used in FF2 but not FF3), and so it should be removed.

Comment 1

[Jez]

Attachment: Patch to remove defunct code from browser.xul

Added patch to remove the offending code.

Comment 2

[Dave Townsend [:mossop]]

Drive by nit: Fix the indentation of attributes to line up with the attribute on the previous line.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 326166 [details] [diff] [review]
Patch to remove defunct code from browser.xul

Yeah, please avoid changing whitespace other than to fix the indentation of star-button and go-button, and do those in such a way that the attributes still line up (and put go-button's chromedir on a new line like the others, for bonus points!)

Comment 4

[Jez]

But you r+ anyway suggests that this is ready for checkin?

Comment 5

[Jez]

Attachment: Patch with nitpicks addresed

Nitpicks addressed

Comment 6

[Jez]

Attachment: Nitpicks addressed again

Third time's the charm.

Comment 7

[Dão Gottwald [:dao]]

Comment on attachment 326310 [details] [diff] [review]
Nitpicks addressed again

>-            <image id="safebrowsing-urlbar-icon" tooltiptext="&safeb.urlbaricon.tooltip;"

Remove safeb.urlbaricon.tooltip from phishing-afterload-warning-message.dtd?

Comment 8

[Jez]

Attachment: Patch v0.4

K, removed that too.

Comment 9

[Dave Townsend [:mossop]]

Landed in changeset f858eb3cce81