44112 - anonymous FTP password error not handled

Status: VERIFIED FIXED

(Core :: Networking, defect, P3)

Description

[carlos]

Use Mozilla to access an ftp server that accepts the anonymous username, but 
does not have anonymous access, (just denies after entering the password).  

For example, GuildFTPD has an anonymous user by default, but the username is 
restricted.  Functionally, the server accepts the username and prompts for the 
password, but sends an error response when the password is entered, for 
example...

220-GuildFTPD FTP Server (c) 1999,2000
220-Version 0.97
220-Sup? Welcome to the FTP server
220-
220 Please enter your name:
USER anonymous
331 User name okay, Need password.
PASS Mozilla@
530 Password not accepted.                                                     
.
.
.
In the mozilla code (netwerk/protocol/ftp/src/nsFTPConnectionThread.cpp), the 
S_pass() function 
(http://lxr.mozilla.org/seamonkey/source/netwerk/protocol/ftp/src/nsFtpConnectio
nThread.cpp#874) checks mAnonymous, but does not check mRetryPass. This causes 
the user not to be prompted (which should be an error message saying that the 
server does not allow anonymous), and Mozilla just sends the same PASS command 
ad nauseum.

Comment 1

[Peter 'Rufus' Nelson]

be nice if you had an example FTP site to test this on

Comment 2

[cheng]

I set up an ftp server on my local machine (but no one else has access to it).
When I tried this, the console just says:

  Error loading URL ftp://xxxxx

whereas Netscape 4.73 popped up a "Login incorrect" box which is nicer.

Reporter: are you still seeing this?  I am using 2000070408 on Linux.

Comment 3

[Michael Hore]

Yep, this is a problem

I set the same thing up on my wu-ftpd server (sticking user ftp in /etc/ftpusers)
here's a sniffing of the chat between browser & server

220 BuffyRox FTP server (Version wu-2.6.0(1) Fri Jun 23 09:17:44 EDT 2000) ready.
USER anonymous
331 Guest login ok, send your complete e-mail address as password.
PASS mozilla@
530 Login incorrect.
PASS mozilla@
503 Login with USER first.
USER anonymous
331 Guest login ok, send your complete e-mail address as password.
PASS mozilla@
530 Login incorrect.
PASS mozilla@
503 Login with USER first.
USER anonymous
331 Guest login ok, send your complete e-mail address as password.
PASS mozilla@
530 Login incorrect.
PASS mozilla@
503 Login with USER first.
USER anonymous
331 Guest login ok, send your complete e-mail address as password.
PASS mozilla@
530 Login incorrect.
PASS mozilla@
503 Login with USER first.
USER anonymous
331 Guest login ok, send your complete e-mail address as password.
PASS mozilla@
530 Login incorrect.
PASS mozilla@

At that point wu-ftpd concluded that it's had quite enough, and terminated the
connection. So it's only by the grace of the ftp server that mozilla stops
trying at all..
btw, I'm using m17 (bid 2000080712) on x86 linux

confirming etc.

Comment 4

[Gagan]

->rjc

Comment 5

[Robert John Churchill]

This was fixed by adding (530) error support.

Comment 6

[Tom Everingham]

verified:
WinNT 2000091308