441140 - Xremote doesn't work when DISPLAY is not set but --display is

Status: RESOLVED FIXED

(Core Graveyard :: X-remote, defect)

Description

[Mike Hommey [:glandium]]

Attachment: patch

While you can run firefox --display=:0 (DISPLAY environment variable not being set), you can't send a remote command with the same way. Instead, the window saying firefox is already running shows up. This is due to Xremote initialization code relying on XOpenDisplay(0), which only uses DISPLAY, while gtk will handle --display perfectly fine.

I see two possible solutions to this:
- PR_SetEnv DISPLAY with the value returned by gdk_get_display_arg_name
- Add a way to pass a display name to XRemoteClient initialization.

I'd go for the first one, which is both simpler and has the advantage to set DISPLAY for all subprocesses, such as helpers, which by the way, fail to start, too, when firefox is run with --display and no DISPLAY.

There might already be surprises with running DISPLAY=:0 firefox --display=:1...

Comment 1

[Mike Hommey [:glandium]]

Erf, firefox is even unable to restart itself (after addon installation for example) when running with --display and no DISPLAY. The first solution is definitely the way to go.

Comment 2

[Mike Hommey [:glandium]]

Attachment: better patch

Comment 3

[Phil Ringnalda (:philor)]

Mike: looks like, since we suck at doing checkin-needed in a timely manner, you bit-rotted yourself with the patch for bug 441137 - patch thinks the patch here still applies, but with some fuzz and a huge offset it puts it in totally the wrong place. If you haven't already fixed this in some other later bug, could we have a new patch, with which we'll try to do better?

Comment 4

[Mike Hommey [:glandium]]

Attachment: unbitrot patch

Comment 5

[Reed Loden [:reed]]

Pushed as 17106:c1290008ed54.