441235 - Shift-tab gets stuck in the comments field in the Mac crashreporter client

Status: VERIFIED FIXED

(Toolkit :: Crash Reporting, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

If you've enabled Full Keyboard Access and are tabbing through the controls in the crashreporter client and you want to tab back from the comments text field to the Details button, you can't; shift tab seems to do nothing once you hit the comments field.

(Moreover, if you've (using opt-tab) inserted some tab characters in the text field, it seems like shift-tab removes those tabs.)

I can't figure out what's causing it offhand; nothing looks wrong in the nib (well, the comments field's nextKeyView is not connected, but even ensuring the loop is fully connected all the way around doesn't seem to fix things); maybe shift-tab is bound to something else in the comments field, given the odd behavior I saw when I'd inserted actual tab chars?

This bug exists on 1.9.0 as well; I was pretty sure it worked right the last time I tested the Mac client, but maybe I missed testing going backwards.

Comment 1

[Håkan Waara]

Attachment: Simple patch

Haven't tested this, but it should fix it. Smokey, can you try it?

The reason for the bug is that the comments field is a custom NSTextView subclass to allow for a placeholder string (which textviews normally don't, I assume).

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

I don't yet have an m-c tree, but I tested this on 1.9.0 and it works perfectly.

--> hwaara; pick your reviewer ;)

Comment 3

[(not currently active) Ted Mielczarek]

Comment on attachment 326268 [details] [diff] [review]
Simple patch

Wow, that's kinda weird, but I guess it makes sense.

Comment 4

[Håkan Waara]

d971499d7eda (with extra merge in e5d5cd06e5e8)

Comment 5

[Håkan Waara]

Smokey, if you want this for CVS, feel free to drive it (and please check in for me then).

Comment 6

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 326268 [details] [diff] [review]
Simple patch

Requesting approval for 1.9.0x.

This is a simple patch that helps accessibility/keyboard users on the Mac by unbreaking a stuck point in the keyboard tab loop.

Comment 7

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

If this gets approved in the next few days, I can land it for Håkan per comment 5, but I'll also be gone most of July, so if it gets approved after I'm away, someone else please land it for us ;)

Comment 8

[Samuel Sidler (old account; do not CC)]

Comment on attachment 326268 [details] [diff] [review]
Simple patch

Approved for 1.9.0.2, a=ss.

Comment 9

[(not currently active) Ted Mielczarek]

Checked into CVS.

Checking in toolkit/crashreporter/client//crashreporter_osx.h;
/cvsroot/mozilla/toolkit/crashreporter/client/crashreporter_osx.h,v  <--  crashr
eporter_osx.h
new revision: 1.12; previous revision: 1.11
done
Checking in toolkit/crashreporter/client//crashreporter_osx.mm;
/cvsroot/mozilla/toolkit/crashreporter/client/crashreporter_osx.mm,v  <--  crash
reporter_osx.mm
new revision: 1.23; previous revision: 1.22
done

Comment 10

[Tony Chung [:tchung]]

Verified fix on Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.0.2pre) Gecko/2008080704 GranParadiso/3.0.2pre.  Shift-tab works for me on the crash reporter.