Closed Bug 441246 Opened 12 years ago Closed 12 years ago

Add support for categories in Google Calendar

Categories

(Calendar :: Provider: GData, enhancement)

enhancement
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: xlonline, Assigned: xlonline)

Details

(Whiteboard: [gdata-0.5])

Attachments

(1 file, 1 obsolete file)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.8.1.14) Gecko/20080404 Firefox/2.0.0.14
Build Identifier: 0.8-0.9pre

Although there exists some code in the extension for storing and retrieving of lighning calendar categories it actually does not work.

Reproducible: Always

Steps to Reproduce:
1.
2.
3.
Attached patch A patch for lighning category support (obsolete) β€” β€” Splinter Review
Hi out there,
i have fixed the problem with categories not showing up or at least
not synchronizing with google cal.
Actually Google has no support for categories yet (or never will have,
who knows?), but as a little workaround google calendar allows to
store extended information as part of an event. So I modified the code
a little bit just to store and retrieve mozillas category information
as an "extendedProperty". The category doesn't show up in google and
cannot be synchronized with Outlook (via Google Calendar Sync) but
it's visible in lightning/sunbird.
Comment on attachment 326258 [details] [diff] [review]
A patch for lighning category support

Axel, thanks for your patch. In order to get it into the tree, it needs to be reviewed. See http://wiki.mozilla.org/Calendar:Module_Ownership for a list of reviewers. In this case, best would be philipp. So I set the flag to ask him to review.
Attachment #326258 - Flags: review?(philipp)
Marking as confirmed per Bug 430051 Comment #5.
Severity: normal → enhancement
Status: UNCONFIRMED → NEW
Ever confirmed: true
Summary: category support is broken → Add support for categories in Google Calendar
Comment on attachment 326258 [details] [diff] [review]
A patch for lighning category support

First of all, thank you for the patch!


>+        var gdCategories = <gd:extendedProperty xmlns:gd={gd}/>;
>+        gdCategories.@name= "CATEGORIES";
>+        gdCategories.@value = categories;
>+        entry.gd::extendedProperty += gdCategories;
I'd prefer a more customized name to not clash with others who potentially use a such general name. I'd suggest "X-MOZ-CATEGORIES".

>+        // Google does not support categories natively, but allows us to store
>+        // data as an "extendedProperty", and here it's going to be retrieved
>+        // again
>+        var gdCategories = aXMLEntry.gd::extendedProperty
>+                         .(@name == "CATEGORIES").@value.toString();
>+        if (gdCategories) item.setProperty("CATEGORIES",gdCategories);
Use brackets even with one-line if(). Also, space after comma. i.e
        if (gdCategories) {
            item.setProperty("CATEGORIES", gdCategories);
        }
See our http://wiki.mozilla.org/Calendar:Style_Guide

r=philipp with comments addressed, please upload a new patch and I'll check it in.
Attachment #326258 - Flags: review?(philipp) → review+
After some remarks of the reviewer I modified the code to comply with the "holy" Mozilla Calendar coding conventions. ;-)
Attachment #326258 - Attachment is obsolete: true
Attachment #326353 - Flags: review?(philipp)
Checked in on HEAD and MOZILLA_1_8_BRANCH

-> FIXED
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [gdata-cvs]
Attachment #326353 - Flags: review?(philipp) → review+
Whiteboard: [gdata-cvs] → [gdata-0.5]
Assignee: nobody → xlonline
You need to log in before you can comment on or make changes to this bug.