441272 - Old Location Bar copies code from multiple add-ons

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Policy, defect, P3)

Description

[Ed Lee :Mardak]

Seth: Just a heads up if you cared.

The Old Location Bar 1.3 add-on pretty much just repackages other add-ons including oldbar, Edit Middle, Hide Unvisited, etc. with the only difference being names/variables renamed to OldLocationBar.

Not quite sure how the add-on makes it act more like the one from Firefox 2 though. The search is still eventually using nsNavHistoryAutoComplete stuff.

Comment 1

[Invertex]

(In reply to comment #0)
> Seth: Just a heads up if you cared.
> 
> The Old Location Bar 1.3 add-on pretty much just repackages other add-ons
> including oldbar, Edit Middle, Hide Unvisited, etc. with the only difference
> being names/variables renamed to OldLocationBar.
> 
> Not quite sure how the add-on makes it act more like the one from Firefox 2
> though. The search is still eventually using nsNavHistoryAutoComplete stuff.
> 

Ah, well then you must not have looked close enough. Because there is more than just the oldbar, hide unvisited, edit middle coding in that add-on. There's some more coding added in to further make it act like FF2's. 

 Currently working on improving it more also.

Comment 2

[Jorge Villalobos [:jorgev] (he/him)]

Kakkoli, has you updated your add-on or descriptions like I asked?

Comment 3

[Invertex]

I had emailed you back saying that I will when I release my next update to the add-on. I haven't really been working on it because I just started college full time. I guess I can add it to the add-on download page though.

Comment 4

[Jorge Villalobos [:jorgev] (he/him)]

That would be enough to close this bug. Please do.

Comment 5

[Invertex]

K, I added it to the Developer Comments section of my add-on's page.

"This add-on was developed with the help of code from the "oldbar" & "Hide Unvisited" add-on's."

Comment 6

[Jorge Villalobos [:jorgev] (he/him)]

Great, thanks. I decided this was enough because the duplicated code is minimal, so I don't think there's any real reason to deal with licensing.

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on https://addons.mozilla.org/en-US/firefox/addon/7637:

Developer Comments

This add-on was developed with the help of code from the "oldbar" & "Hide Unvisited" add-on's.

Comment 8

[Jorge Villalobos [:jorgev] (he/him)]

Reclassifying editor bugs and changing to a new whiteboard flag. Spam, spam, spam, spam...