Old Location Bar copies code from multiple add-ons

VERIFIED FIXED in 5.4

Status

P3
minor
VERIFIED FIXED
11 years ago
3 years ago

People

(Reporter: Mardak, Assigned: jorgev)

Tracking

unspecified

Details

(Whiteboard: [ReviewTeam], URL)

(Reporter)

Description

11 years ago
Seth: Just a heads up if you cared.

The Old Location Bar 1.3 add-on pretty much just repackages other add-ons including oldbar, Edit Middle, Hide Unvisited, etc. with the only difference being names/variables renamed to OldLocationBar.

Not quite sure how the add-on makes it act more like the one from Firefox 2 though. The search is still eventually using nsNavHistoryAutoComplete stuff.

Comment 1

11 years ago
(In reply to comment #0)
> Seth: Just a heads up if you cared.
> 
> The Old Location Bar 1.3 add-on pretty much just repackages other add-ons
> including oldbar, Edit Middle, Hide Unvisited, etc. with the only difference
> being names/variables renamed to OldLocationBar.
> 
> Not quite sure how the add-on makes it act more like the one from Firefox 2
> though. The search is still eventually using nsNavHistoryAutoComplete stuff.
> 

Ah, well then you must not have looked close enough. Because there is more than just the oldbar, hide unvisited, edit middle coding in that add-on. There's some more coding added in to further make it act like FF2's. 

 Currently working on improving it more also.
Assignee: nobody → jorge
Severity: normal → minor
Priority: -- → P3
Target Milestone: --- → 5.4
(Assignee)

Comment 2

9 years ago
Kakkoli, has you updated your add-on or descriptions like I asked?
Target Milestone: 5.4 → 5.5

Comment 3

9 years ago
I had emailed you back saying that I will when I release my next update to the add-on. I haven't really been working on it because I just started college full time. I guess I can add it to the add-on download page though.
(Assignee)

Comment 4

9 years ago
That would be enough to close this bug. Please do.

Comment 5

9 years ago
K, I added it to the Developer Comments section of my add-on's page.

"This add-on was developed with the help of code from the "oldbar" & "Hide Unvisited" add-on's."
(Assignee)

Comment 6

9 years ago
Great, thanks. I decided this was enough because the duplicated code is minimal, so I don't think there's any real reason to deal with licensing.
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
(Assignee)

Updated

9 years ago
Whiteboard: [required amo-editors]
Target Milestone: 5.5 → 5.4
Verified FIXED on https://addons.mozilla.org/en-US/firefox/addon/7637:

Developer Comments

This add-on was developed with the help of code from the "oldbar" & "Hide Unvisited" add-on's.
Status: RESOLVED → VERIFIED
(Assignee)

Comment 8

7 years ago
Reclassifying editor bugs and changing to a new whiteboard flag. Spam, spam, spam, spam...
Whiteboard: [required amo-editors] → [ReviewTeam]
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.