Closed
Bug 441303
Opened 16 years ago
Closed 16 years ago
jsutil.cpp does not compile with Visual Studio 2003
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: longsonr, Unassigned)
Details
Attachments
(1 file)
526 bytes,
patch
|
crowderbt
:
review+
|
Details | Diff | Splinter Review |
Compiler cannot determine which pow overload to use.
Attachment #326301 -
Flags: review?(crowder)
Comment 1•16 years ago
|
||
What error messages do you see for this? I'm surprised VC has multiple definitons of pow()... powl() and powf() are standard math.h functions, I think?
Reporter | ||
Comment 2•16 years ago
|
||
This is what I get... jsutil.cpp(92) : error C2666: 'pow' : 7 overloads have similar conversions C:\Program Files\Microsoft Visual Studio .NET 2003\Vc7\include\math.h(620): could be 'long double pow(long double,int)' C:\Program Files\Microsoft Visual Studio .NET 2003\Vc7\include\math.h(618): or 'long double pow(long double,long double)' C:\Program Files\Microsoft Visual Studio .NET 2003\Vc7\include\math.h(572): or 'float pow(float,int)' C:\Program Files\Microsoft Visual Studio .NET 2003\Vc7\include\math.h(570): or 'float pow(float,float)' C:\Program Files\Microsoft Visual Studio .NET 2003\Vc7\include\math.h(534): or 'double pow(int,int)' C:\Program Files\Microsoft Visual Studio .NET 2003\Vc7\include\math.h(532): or 'double pow(double,int)' C:\Program Files\Microsoft Visual Studio .NET 2003\Vc7\include\math.h(195): or 'double pow(double,double)' while trying to match the argument list '(int, double)' make[1]: *** [jsutil.obj] Error 2
Comment 3•16 years ago
|
||
Comment on attachment 326301 [details] [diff] [review] patch Good to see Microsoft isn't afraid to abuse function-overloading. :(
Attachment #326301 -
Flags: review?(crowder) → review+
Comment 4•16 years ago
|
||
Robert: Are you able to land this, or shall I?
Reporter | ||
Comment 5•16 years ago
|
||
Is js still a closed partition or has that all gone away in the brave new hg world? I have general commit privileges so if there's nothing special about js any more I can land it.
Comment 6•16 years ago
|
||
Looks like you should be able to land away, if/when the tree is happy.
Reporter | ||
Comment 7•16 years ago
|
||
checked in.
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Updated•16 years ago
|
Flags: in-testsuite-
Flags: in-litmus-
You need to log in
before you can comment on or make changes to this bug.
Description
•