Closed Bug 441342 Opened 14 years ago Closed 14 years ago

Get rid of empty <contextHelp.js>

Categories

(Thunderbird :: General, defect)

defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3

People

(Reporter: sgautherie, Assigned: sgautherie)

References

Details

Attachments

(1 file, 2 obsolete files)

While working on bug 441220, I noticed:

<http://bonsai.mozilla.org/cvslog.cgi?file=/mozilla/mail/base/content/contextHelp.js&rev=HEAD&mark=1.1>
{{
1.1	scott%scott-macgregor.org	2003-05-02 19:44	 	View source work (not complete yet)
Work to try to remove the "contextHelp.js" file not found error by using a dummy version.
}}

<http://mxr.mozilla.org/mailnews/search?string=contextHelp.js&filter=%5E%5B%5E%5C0%5D*%24&tree=mailnews>
{{
/mail/config/mail-jar.mn
    * line 44 -- # dummy contextHelp.js file so we don't get a bunch of errors about this file not being found
    * line 45 -- content/help/contextHelp.js, comm/content/help/contextHelp.js

/mail/extensions/smime/content/msgCompSecurityInfo.xul
    * line 52 -- <script type="application/x-javascript" src="chrome://help/content/contextHelp.js"/>

/mail/base/jar.mn
    * line 127 -- + content/help/contextHelp.js (content/contextHelp.js)

/mail/base/content/FilterListDialog.xul
    * line 58 -- <script type="application/x-javascript" src="chrome://help/content/contextHelp.js"/>
}}
Assignee: nobody → sgautherie.bz
Status: NEW → ASSIGNED
Attachment #326336 - Flags: review?(philringnalda)
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.0.1pre) Gecko/2008062303 Thunderbird/3.0a2pre] (nightly) (W2Ksp4)

Other files included in Thunderbird:

<http://mxr.mozilla.org/seamonkey/search?string=contextHelp.js&filter=%5E%5B%5E%5C0%5D*%24&tree=seamonkey>
{{
/security/manager/pki/resources/content/createCertInfo.xul
    * line 51 -- <script type="application/x-javascript" src="chrome://help/content/contextHelp.js" />
/security/manager/pki/resources/content/formsigning.xul
    * line 57 -- <script type="application/x-javascript" src="chrome://help/content/contextHelp.js" />

/extensions/wallet/walletpreview/resources/content/WalletPreview.xul
    * line 59 -- <script type="application/x-javascript" src="chrome://help/content/contextHelp.js"/>
/extensions/wallet/editor/resources/content/WalletViewer.xul
    * line 23 -- <script type="application/x-javascript" src="chrome://help/content/contextHelp.js"/>
/extensions/wallet/signonviewer/resources/content/SignonViewer.xul
    * line 59 -- <script src="chrome://help/content/contextHelp.js"/>
}}

The 3 (Xpfe) Wallet files should (soon) go away after (SM &) TB switch to (Toolkit) LoginManager.
Looking for advice about the 2 PKI files.
(In reply to comment #2)
> /security/manager/pki/resources/content/createCertInfo.xul
>     * line 51 -- <script type="application/x-javascript"
> src="chrome://help/content/contextHelp.js" />
> /security/manager/pki/resources/content/formsigning.xul
>     * line 57 -- <script type="application/x-javascript"
> src="chrome://help/content/contextHelp.js" />
...
> Looking for advice about the 2 PKI files.

Does Firefox include/use these two files, if so, does it get warnings about contextHelp.js? Does Thunderbird really use these anywhere?

Its a little confusing after a brief look, but although there's a core contextHelp.js I'm fairly sure Firefox doesn't include it.
Firefox doesn't include it, having recently joined us in not building toolkit/components/help/. It does get a message (no chrome package registered is neither an error nor a warning) on createCertInfo.xul (STR: load data:text/html,<form><keygen name="goats"><input type="submit"></form> and submit it), but formsigning.xul? Dunno, you'd have to have a personal cert installed and then <script>crypto.signText("foo", "ask")</script> ought to bring it up, and ought to produce a message.

Given the odds of anyone ever seeing either one in a product that doesn't do form submission and disables script by default, I'd say you should just land removing our empty file and our what-were-we-thinking includes of it (all of them, in one patch, not one per file please), and let Kai decide what he wants to do about his stuff (which, in the case of createCertInfo.xul is a self-closing progress dialog, so I really wonder how often SeaMonkey users manage to trigger help on it, much less whether there's any context-sensitive help, like "You have no choices here. Sit quietly and read the message that you need to wait."), unless he already has a bug on it.
(In reply to comment #3)
> Does Thunderbird really use these anywhere?

Maybe not.

The only (direct) callers are:

{{
/security/manager/pki/src/nsNSSDialogs.cpp
    * line 483 -- "chrome://pippki/content/createCertInfo.xul",

/security/manager/pki/src/nsFormSigningDialog.cpp
    * line 98 -- "chrome://pippki/content/formsigning.xul",
}}

And about Wallet:

{{
/extensions/wallet/resources/content/walletOverlay.js
    * line 160 -- window.openDialog("chrome://communicator/content/wallet/WalletPreview.xul",

/extensions/wallet/resources/content/walletOverlay.js
    * line 141 -- "chrome://communicator/content/wallet/WalletViewer.xul",
}}
are related to forms, so probably unused by TB.

And TB Options can open <SignonViewer.xul>, though I'm not too sure how it is done [a different forked file !?], but there's no msg/wng/err about the help file :->
(In reply to comment #5)
> there's no msg/wng/err about the help file :->

... (when removing it)
Attached patch (Av2) <mail/*> (obsolete) — Splinter Review
<http://mxr.mozilla.org/mozilla/search?string=content%2Fhelp&filter=%5E%5B%5E%5C0%5D*%24&tree=mozilla>
Should
{{
% content help %content/help/ xpcnativewrappers=yes
}}
be removed too ?
Or kept, for others to use, like Pki, Venkman, ... ?

***

{{
/mail/config/installed-chrome.txt
/mail/config/mail-jar.mn
}}
give me
{{
cvs checkout: warning: mozilla/mail/config/* is not (any longer) pertinent
}}
then I can't update them...

***

</mail/base/content/contextHelp.js>
will need to be cvs removed too.
Attachment #326336 - Attachment is obsolete: true
Attachment #326403 - Flags: review?(philringnalda)
Attachment #326336 - Flags: review?(philringnalda)
(In reply to comment #8)
> FilterListDialog.xul#57 ?

Included in bug 441220.

***

(In reply to comment #4)
> let Kai decide what he wants to do about his stuff

I filed bug 441425.
Comment on attachment 326403 [details] [diff] [review]
(Av2) <mail/*>

(In reply to comment #7)
> Should % content help %content/help/ xpcnativewrappers=yes
> be removed too ?

Yes.

> /mail/config/installed-chrome.txt
> /mail/config/mail-jar.mn
> 
> give me
> 
> cvs checkout: warning: mozilla/mail/config/* is not (any longer) pertinent
> 
> then I can't update them...

Yes, that's correct. They were both removed almost a year ago, if you still have them in your tree then you're updating it the wrong way.
Attachment #326403 - Flags: review?(philringnalda) → review-
Av2, with comment 10 suggestion(s).
Attachment #326403 - Attachment is obsolete: true
Attachment #327374 - Flags: review?(philringnalda)
(In reply to comment #10)
> Yes, that's correct. They were both removed almost a year ago, if you still
> have them in your tree then you're updating it the wrong way.

MXR issue ... I filed bug 442647.
Depends on: 441425
Attachment #327374 - Flags: review?(philringnalda) → review+
mail/base/jar.mn 1.115
mail/extensions/smime/content/msgCompSecurityInfo.xul 1.6
mail/base/content/contextHelp.js delete
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Attachment #327374 - Attachment description: (Av3) <mail/*> → (Av3) <mail/*> [Checkin: Comment 13]
Blocks: 442838
You need to log in before you can comment on or make changes to this bug.