Closed
Bug 441377
Opened 16 years ago
Closed 16 years ago
JS GC triggered on startup
Categories
(Core :: General, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: sayrer, Unassigned)
Details
(Keywords: mobile, Whiteboard: startup)
Attachments
(1 file)
550 bytes,
patch
|
brendan
:
review+
brendan
:
superreview+
|
Details | Diff | Splinter Review |
Early in startup, JS GC is being triggered. CPU1 - firefox-bin [259] Thread 0x4B56B58 User 23 fun_trace(JSTracer*, JSObject*) 22 js_TraceObject 21 JS_CallTracer 20 fun_trace(JSTracer*, JSObject*) 19 js_TraceObject 18 JS_CallTracer 17 js_TraceObject 16 JS_CallTracer 15 js_CallValueTracerIfGCThing 14 gc_root_traversal(JSDHashTable*, JSDHashEntryHdr*, unsigned, void*) 13 JS_DHashTableEnumerate 12 js_TraceRuntime 11 js_GC 10 js_DestroyContext 9 JS_DestroyContext 8 XPCJSContextStack::SetSafeJSContext(JSContext*) 7 nsAppShellService::SetXPConnectSafeContext() 6 nsAppShellService::CreateHiddenWindow(nsIAppShell*) 5 nsAppStartup::CreateHiddenWindow() 4 XRE_main 3 main 2 _start 1 start [STACK TOP]
Reporter | ||
Updated•16 years ago
|
Whiteboard: startup
Comment 1•16 years ago
|
||
Ah, the good old hidden window. Blake, Johnny: why are we destroying a context when setting a "safe" one here? I hope this isn't some Mac-only drain bamage from the old days. /be
Comment 2•16 years ago
|
||
Early on in XPConnect's life, before we hand it the safe context we want it to use, it needs a safe context so it creates its own. In the above stack we're replacing the safe context that XPConnect created with the new one and thus deleting the old one that it had created, and that triggers a GC. The obvious fix here seems to be to call JS_DestroyContextNoGC() in this case. Patch coming up.
Comment 3•16 years ago
|
||
Attachment #326408 -
Flags: superreview?(brendan)
Attachment #326408 -
Flags: review?(brendan)
Updated•16 years ago
|
Attachment #326408 -
Flags: superreview?(brendan)
Attachment #326408 -
Flags: superreview+
Attachment #326408 -
Flags: review?(brendan)
Attachment #326408 -
Flags: review+
Comment 4•16 years ago
|
||
Fix checked in.
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•