441429 - In <FilterEditor.xul>, "Warning: Failed to load overlay from chrome://messenger/content/msgFolderPickerOverlay.xul."

Status: VERIFIED FIXED

(Thunderbird :: General, defect)

Description

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.0.1pre) Gecko/2008062303 Thunderbird/3.0a2pre] (nightly) (W2Ksp4)

1. Start TB.
2. Tools > Message Filters... > New
2r.
{{
Warning: Failed to load overlay from chrome://messenger/content/msgFolderPickerOverlay.xul.
Source File: chrome://messenger/content/FilterEditor.xul
Line: 0
}}

***

With a new profile, I also get
{{
Error: no element found
Source File: chrome://messenger/content/msgFolderPickerOverlay.xul
Line: 1

Error: gSearchTermList is null
Source File: chrome://messenger/content/searchTermOverlay.js
Line: 254
}}

All 3 might be related or different bugs:
first, fix the overlay load, then, we'll see...

Comment 1

[Joey Minta]

Attachment: patch v1

This is another one of those bugs that's not visible in my/philor's cvs builds, but does show up in tinderbox builds.  This is also a classic example of the problems that happen when you include a whole overlay instead of just the files you need.

Comment 2

[David Ascher (:davida)]

applying this patch fixes bug 439763 for me.

Comment 3

[David Ascher (:davida)]

Note: i did notice that on my mac the xul elements in the actions area scale up when the panel width is increased (by dragging the bottom right handle), but then don't scale down when the panel width is shrunk (until the dialog gets closed & reopened).

Comment 4

[Serge Gautherie (:sgautherie)]

(In reply to comment #2)
> applying this patch fixes bug 439763 for me.

They are duplicates actually (= I'm seeing bug 4439763 symptoms too.);
but mine has the patch and yours has the blocking flags ;->

Comment 5

[David Ascher (:davida)]

carrying flags over here (patches w/ reviews trump all). I'll dupe 439763.

Comment 7

[Joey Minta]

Patch checked in.

Checking in mailnews/base/search/resources/content/FilterEditor.xul;
/cvsroot/mozilla/mailnews/base/search/resources/content/FilterEditor.xul,v  <--  FilterEditor.xul
new revision: 1.90; previous revision: 1.89
done

Comment 8

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.0.1pre) Gecko/2008062503 Thunderbird/3.0a2pre] (nightly) (W2Ksp4)

V.Fixed

The error I was getting on second opening is gone too:
{{
Error: SetFolderPickerElement is not defined
Source File: chrome://messenger/content/searchWidgets.xml
Line: 515
}}

Comment 9

[Serge Gautherie (:sgautherie)]

(In reply to comment #3)
> Note: i did notice that on my mac the xul elements in the actions area scale up

Bug 399771 ;-)