garburator: Inner classes are rewritten as if they were the outer class

RESOLVED FIXED

Status

RESOLVED FIXED
11 years ago
11 months ago

People

(Reporter: benjamin, Assigned: taras.mozilla)

Tracking

Trunk
x86
Linux

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

11 years ago
Testcase already committed: http://hg.mozilla.org/index.cgi/oink/rev/c9fc8a4228a9

An outer class is marked stack-only; the inner class constructor is rewritten to initialize all the *outer* class members.

1) the inner class isn't stack-only
2) even if it were, we should only initialize the inner-class members, not the outer-class members
(Assignee)

Comment 1

11 years ago
Created attachment 326507 [details] [diff] [review]
this should work

if this weren't the last possible garburator bug, I'd suggest than in the future it'd be nicer to just attach testcase mods as a patch.
Attachment #326507 - Flags: review?(benjamin)
(Reporter)

Updated

11 years ago
Attachment #326507 - Flags: review?(benjamin) → review+
(Assignee)

Comment 2

11 years ago
pushed
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED

Updated

11 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.