441584 - Panning leaves white space

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Panning/Zooming, defect, P1)

Description

[Doug Turner (:dougt)]

If I end a pan outside of the content area, the content area is not refreshed.

For example, if I click in the center of the page, then drag my finger over the urlbar and release, the content area remain white and does not refresh.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

- _scrollStartTimeout checks removed (redundant, checking .dragging is sufficient)
- factored some code out into a more descriptive method (_endPan)
- moved .dragging = false; to _endPan. Only reason is was done unconditionally in mouseup was as a workaround for this bug (so you could at least click to refresh)

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 326592 [details] [diff] [review]
patch

>diff --git a/chrome/content/deckbrowser.xml b/chrome/content/deckbrowser.xml

>+            if (aEvent.button == 0 && this.deckbrowser.dragData.dragging) {

aEvent.button == 0 isn't that critical is it? But will help when testing on desktop.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Actually there's a problem with that patch - it interferes with clicks on the location bar (because it preventDefault()s the mouseup). We don't want to redispatch the click for mouseups on the toolbar, either. Also the preventDefault()s and returns are unneeded afaict.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Attachment: updated patch

Comment 5

[:Gavin Sharp [email: [e-mail]]]

http://hg.mozilla.org/mobile-browser/index.cgi/rev/cb7f12c5617d

Comment 6

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #2)
> aEvent.button == 0 isn't that critical is it? But will help when testing on
> desktop.

yeah, exactly.

Comment 7

[Joel Maher ( :jmaher ) (UTC -8)]

verified with beta3