441619 - icc/icpc doesn't compile mozilla-central spidermonkey on OS X

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Robert Sayre]

icc 10.1.14

icpc -m32 -o jsinterp.o -c  -DOSTYPE=\"Darwin9.3.0\" -DOSARCH=Darwin -DEXPORT_JS_API  -DJS_USE_SAFE_ARENA  -I/Users/sayrer/dev/icc/src/js/src -I.  -I../../dist/include   -I/Users/sayrer/dev/icc/obj-firefox-icc/i386/dist/include -I../../dist/include/js -I/Users/sayrer/dev/icc/obj-firefox-icc/i386/dist/include/nspr     -I/Users/sayrer/dev/icc/obj-firefox-icc/i386/dist/sdk/include -I/Users/sayrer/dev/icc/src/js/src -I/usr/X11/include   -fPIC  -I/usr/X11/include -fno-rtti -fno-handle-exceptions -Wall -Wconversion -Wpointer-arith -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -g -isysroot /Developer/SDKs/MacOSX10.5.sdk -fno-strict-aliasing -fpascal-strings -fno-common -fshort-wchar -pthread -I/Developer/SDKs/MacOSX10.5.sdk/Developer/Headers/FlatCarbon -pipe  -DNDEBUG -DTRIMMED -O2 -ip  -I/usr/X11/include -DMOZILLA_CLIENT -include ../../mozilla-config.h -Wp,-MD,.deps/jsinterp.pp /Users/sayrer/dev/icc/src/js/src/jsinterp.cpp



/Users/sayrer/dev/icc/src/js/src/jsinterp.cpp(2794): error: in "goto *expr", expr must have type "void *"
      DO_NEXT_OP(len);
      ^

/Users/sayrer/dev/icc/src/js/src/jsinterp.cpp(2850): error: in "goto *expr", expr must have type "void *"
              JS_EXTENSION_(goto *normalJumpTable[op]);
              ^

/Users/sayrer/dev/icc/src/js/src/jsinterp.cpp(2858): error: in "goto *expr", expr must have type "void *"
            ADD_EMPTY_CASE(JSOP_NOP)
            ^

Comment 1

[Igor Bukanov]

This is a regression from the bug 433382. Apparently in "goto *expr;" GCC allows const void*, not only void*, as a type of expr. 

Comment 2

[Igor Bukanov]

To clarify the semantics of computed goto and const pointers I posted this question to gcc-help mail list,

http://gcc.gnu.org/ml/gcc-help/2008-06/msg00299.html

Comment 3

[Igor Bukanov]

Attachment: fix v1

The fix just strips const from the type of the computed goto label.

Comment 4

[Igor Bukanov]

I pushed the fix to mozilla-cenrtral:

changeset:   15523:35005e434739
tag:         tip
parent:      15521:79c0748ff2ac
user:        Igor Bukanov <[e-mail]>
date:        Tue Jun 24 22:31:16 2008 +0200
summary:     [Bug 441619] Fixing ICC compilation issue: in goto *expr the type of expr should be void*. r=sayrer