441651 - add rewrites to support old link format

Status: RESOLVED FIXED

(Webtools Graveyard :: Graph Server, defect)

Description

[alice nodelman [:alice] [:anode]]

The new front end of the graph server uses a new link format.  We should continue to support the old format so that old links continue to work after we retire the old front end.

Comment 1

[Michael Morgan [:morgamic]]

Can someone supply the old link format and the new link format?

Comment 2

[Les Orchard [:lorchard]]

Reassigning for now, since Alice has much stronger link-format-fu than I do.  Adding myself as CC to stay in the loop, or to re-claim the bug if necessary.

Comment 3

[alice nodelman [:alice] [:anode]]

Attachment: [Checked in]have new front end understand old format links

This handles some of basic differences between old and new link formats and should cover 90-95% of all the outstanding links to the graph server.

What it does _not handle is the case for links to dgraph.html - which should become links to graph.html#type=series.  There is some question about how to handle that and maintain/pass around the hash associated with the original link.

Comment 4

[alice nodelman [:alice] [:anode]]

Attachment: [Checked in]simple solution for dgraph.html -> graph.html#type=series

This should cover the rest.

Comment 5

[Michael Morgan [:morgamic]]

Comment on attachment 329896 [details] [diff] [review]
[Checked in]have new front end understand old format links

wfm - let's test on graph-stage

Comment 6

[Michael Morgan [:morgamic]]

Comment on attachment 329899 [details] [diff] [review]
[Checked in]simple solution for dgraph.html -> graph.html#type=series

wfm too -- let's test on graph-stage

Comment 7

[alice nodelman [:alice] [:anode]]

Comment on attachment 329899 [details] [diff] [review]
[Checked in]simple solution for dgraph.html -> graph.html#type=series

changeset:   94:944bd03c187f

Comment 8

[alice nodelman [:alice] [:anode]]

Comment on attachment 329896 [details] [diff] [review]
[Checked in]have new front end understand old format links

changeset:   95:d7b7c30af1d5

Comment 9

[alice nodelman [:alice] [:anode]]

Old links are now working, _except_ those links to old series data - the 'Include tests without recent data' options appears to override the attempt to link to old data.

Filed as a separate bug 446056.