441716 - test_retention_is_0_closes.xul is flakey on linux

Status: RESOLVED FIXED

(Toolkit :: Downloads API, defect)

Description

[Shawn Wilsher :sdwilsh]

There's a timer involved that I can probably make a bit better.  Hopefully it'll help with the random orangeness on linux.

Comment 1

[Shawn Wilsher :sdwilsh]

Attachment: v1.0

This was "fun"

Comment 2

[Shawn Wilsher :sdwilsh]

Comment on attachment 326968 [details] [diff] [review]
v1.0

actually, I don't think Edward is reading bugmail...

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 326968 [details] [diff] [review]
v1.0

>diff --git a/toolkit/mozapps/downloads/tests/chrome/test_retention_is_0_closes.xul b/toolkit/mozapps/downloads/tests/chrome/test_retention_is_0_closes.xul

>+function setPref(aDoTest)

>+  // If we're testing, set retention to auto-remove and auto-close
>+  prefs.setIntPref("browser.download.manager.retention", aDoTest ? 0 : 2);
>+  prefs.setBoolPref("browser.download.manager.closeWhenDone", aDoTest);

(Not related to this bug, but the intention is that this resets prefs to default if aDoTest is false, right? If so, do that explicitly with clearUserPref? Protects against weirdness should the defaults ever change.)

>-      ww.unregisterNotification(this);

shouldn't you move this to the domwindowclosed handler?

Comment 4

[Shawn Wilsher :sdwilsh]

(In reply to comment #3)
> (From update of attachment 326968 [details] [diff] [review])
> (Not related to this bug, but the intention is that this resets prefs to
> default if aDoTest is false, right? If so, do that explicitly with
> clearUserPref? Protects against weirdness should the defaults ever change.)
I didn't even know about that.  Filed bug 442099 to fix this in all our tests.

> >-      ww.unregisterNotification(this);
> 
> shouldn't you move this to the domwindowclosed handler?
Er, yes, and I though I had.  Interesting that it didn't end up causing a leak either...

Comment 5

[Shawn Wilsher :sdwilsh]

Attachment: v1.1

addresses review comments

Comment 6

[Shawn Wilsher :sdwilsh]

Pushed to mozilla-central:
http://hg.mozilla.org/mozilla-central/index.cgi/rev/42cafa4b181f