441808 - Replace "#expand __Var__" by "@Var@", in </mail/*>

Status: RESOLVED WONTFIX

(Thunderbird :: Build Config, defect)

Description

[Serge Gautherie (:sgautherie)]

While looking at
<http://mxr.mozilla.org/mozilla/search?string=general.useragent.locale&find=/mail/&filter=%5E%5B%5E%5C0%5D*%24&tree=mozilla>

I wondered if
|#expand pref("general.useragent.locale", "__AB_CD__");|
could be replaced by
|pref("general.useragent.locale", "@AB_CD@");|
as it seems to be "everywhere" else.

Comment 1

[Mark Banner (:standard8)]

(In reply to comment #0)
> While looking at
> <http://mxr.mozilla.org/mozilla/search?string=general.useragent.locale&find=/mail/&filter=%5E%5B%5E%5C0%5D*%24&tree=mozilla>
> 
> I wondered if
> |#expand pref("general.useragent.locale", "__AB_CD__");|
> could be replaced by
> |pref("general.useragent.locale", "@AB_CD@");|
> as it seems to be "everywhere" else.

It certainly looks that way. I'd be interested in seeing if there's a define or something in a makefile for __AB_CD__ instead of @AB_CD@, as well as doing the change.

Comment 2

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) <all-thunderbird.js>

(In reply to comment #1)
> I'd be interested in seeing if there's a define or
> something in a makefile for __AB_CD__ instead of @AB_CD@

<http://mxr.mozilla.org/mozilla/search?string=__AB_CD__&case=on&filter=%5E%5B%5E%5C0%5D*%24&tree=mozilla>
There is none.

<http://mxr.mozilla.org/mozilla/source/config/preprocessor.txt#154>
"__ : empty string if they are not defined.
 @  : not defined, the preprocessor will terminate with a fatal error."

Comment 3

[Mark Banner (:standard8)]

Comment on attachment 326724 [details] [diff] [review]
(Av1) <all-thunderbird.js>

#expand pref("general.useragent.extra.thunderbird", "Thunderbird/__APP_VERSION__");
 
How about doing this one at the same time? (Note, leave "Thunderbird" as it is please), just the app version.

Comment 4

[Serge Gautherie (:sgautherie)]

Attachment: (Av1a) <all-thunderbird.js>

Av1, with comment 3 suggestion(s).

Comment 5

[Serge Gautherie (:sgautherie)]

Attachment: (Bv1) </mail/base/content/*>

The remaining occurrences in </mail/*> from
<http://mxr.mozilla.org/mailnews/search?string=%5E%5C%23expand+&regexp=on&find=%2Fmail%2F%5E%5B%5E%5C0%5D*%24&tree=mailnews>

(untested either)

Comment 6

[Mark Banner (:standard8)]

Comment on attachment 326925 [details] [diff] [review]
(Av1a) <all-thunderbird.js>

This doesn't work, I end up with the processed file showing these lines the same as the unprocessed file.

Comment 7

[Mark Banner (:standard8)]

Comment on attachment 326927 [details] [diff] [review]
(Bv1) </mail/base/content/*>

I'd like to know what Core thinks about changing these globally. I'm happy with the prefs.js ones because thats what the others do.

Therefore cancelling review for the time being, please re-request once you know what is happening with the dependent bug.

Comment 8

[Serge Gautherie (:sgautherie)]

Comment on attachment 326927 [details] [diff] [review]
(Bv1) </mail/base/content/*>

Bug 451601 removed the <help.rdf> part :-)

Comment 9

[Robert Kaiser]

I don't see why why should switch expand/subsitution in all files, is #expand planned to be removed from the preprocessor or is this just doing changes for change's sake?

Comment 10

[Serge Gautherie (:sgautherie)]

(In reply to comment #9)

I replied in bug 441853 comment 2.

Comment 11

[Mark Banner (:standard8)]

Won't fix in a similar style to bug 441853