Closed
Bug 441866
Opened 16 years ago
Closed 16 years ago
Build the toolkit url-classifier component for use with Camino's safe browsing feature.
Categories
(Camino Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: murph, Assigned: murph)
References
Details
(Keywords: fixed1.9.0.2)
Attachments
(1 file)
681 bytes,
patch
|
mark
:
review+
samuel.sidler+old
:
approval1.9.0.2+
|
Details | Diff | Splinter Review |
For use with bug 358299 and our safe browsing feature, we need to update the toolkit/components Makefile to build us an intermediary url-classifier static library. Filing as a separate bug so we can get this external change taken care of without having to wait for bug 358299. This intermediary static library is later used by the Camino safe browsing XPCOM component library up in our tree, rather than attempting to build and link the entire toolkit component library with Camino.
Attachment #326747 -
Flags: review?(mark)
Updated•16 years ago
|
Attachment #326747 -
Flags: review?(mark) → review+
Comment on attachment 326747 [details] [diff] [review] Makefile Patch Requesting 1.9.0.1 approval for this build-config-only change. This change only affects Camino (and is required for our safebrowsing implementation).
Attachment #326747 -
Flags: approval1.9.0.1?
Comment 2•16 years ago
|
||
Comment on attachment 326747 [details] [diff] [review] Makefile Patch Requesting approval on this patch to land in 1.9.0.1. This patch simply allows Camino to build url-classifier, which it needs to do the fun anti-phishing/anti-malware features. It has virtually no risk given that it's in a Camino-specific section of the makefile. I can haz aproval?
Updated•16 years ago
|
Attachment #326747 -
Flags: approval1.9.0.1? → approval1.9.0.2?
Comment 3•16 years ago
|
||
Comment on attachment 326747 [details] [diff] [review] Makefile Patch Approved for 1.9.0.2. Please land in CVS. a=ss
Attachment #326747 -
Flags: approval1.9.0.2? → approval1.9.0.2+
Landed on cvs trunk for 1.9.0.2.
You need to log in
before you can comment on or make changes to this bug.
Description
•