bugzilla.mozilla.org has resumed normal operation. Attachments prior to 2014 will be unavailable for a few days. This is tracked in Bug 1475801.
Please report any other irregularities here.

Certain icons disappear in Bookmarks Toolbar when no browser window is focused

NEW
Unassigned

Status

()

Firefox
Theme
P4
normal
10 years ago
5 years ago

People

(Reporter: dschafer, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Reporter)

Description

10 years ago
Created attachment 326843 [details]
Screenshot of Bookmarks menu appearing without icons

If there is no browser window open, the bookmarks menu has some of its icons missing, most noticeably the folder and "smart folder" icons.

Steps to reproduce:
0. Create a new profile (optional, but this is what I did in generating the screenshot attached)
1. Open a browser window
2. Click on bookmarks menu
3. Close all browser windows
4. Click on bookmarks menu

Actual results:
In step 2, the icons appear.  In step 4, they do not.

Expected results:
In both step 2 and 4, the icons appear.

Build Date & Platform:
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1a1pre) Gecko/2008062402 Minefield/3.1a1pre
Mac OS X 10.5.2

Additional Builds and Platforms:
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9) Gecko/2008061004 Firefox/3.0
Mac OS X 10.5.3
(Reporter)

Comment 1

10 years ago
Created attachment 326844 [details]
Screenshot of Bookmarks menu appearing with icons (with browser window open)
I'm able to reproduce this with both FF3 and FF2, in both OS X 10.5.3
and 10.4.11.

But you don't need to close all browser windows besides the Download
window.  This problem happens when no "normal" browser window has the
focus.

So it happens when 1) no browser windows of any kind are open, 2) when
only the Download window is open, or 3) when the Download window has
the keyboard focus (when it's "above" every "normal" browser window).

I have no idea why this happens, but I suspect it's a widgets problem.
Assignee: nobody → joshmoz
Component: Bookmarks → Widget: Cocoa
Product: Firefox → Core
QA Contact: bookmarks → cocoa
Version: Trunk → unspecified
Assignee: joshmoz → smichaud
Priority: -- → P4
Summary: Certain icons disappear in Bookmarks Toolbar when no browser window open → Certain icons disappear in Bookmarks Toolbar when no browser window is focused
Duplicate of this bug: 526166
Duplicate of this bug: 733340
Created attachment 606678 [details] [diff] [review]
Patch v0.1

The problem here is that the list-item-image css rule for .bookmark-items is in the themes browser.css.

This fixes it, but not sure if it has side effects. It might make more sense to just move that rule into places.css, which is already included in the overlay.
Attachment #606678 - Flags: review?(dao)

Updated

6 years ago
Duplicate of this bug: 739164
I think a dedicated places stylesheet is probably going to be the cleaner solution...

Updated

6 years ago
Assignee: smichaud → nobody
Component: Widget: Cocoa → Theme
Product: Core → Firefox
QA Contact: cocoa → theme

Updated

6 years ago
Attachment #606678 - Flags: review?(dao) → review?(mano)
Comment on attachment 606678 [details] [diff] [review]
Patch v0.1

What Dão said. Any change to macBrowserOverlay affects quite a few windows.
Attachment #606678 - Flags: review?(mano) → review-
You need to log in before you can comment on or make changes to this bug.