Open Bug 442189 Opened 14 years ago Updated 6 years ago

Synchronize SM and TB <msgHdrViewSMIMEOverlay.js>

Categories

(MailNews Core :: Security, defect)

defect
Not set
minor

Tracking

(Not tracked)

ASSIGNED
mozilla1.9.1a1

People

(Reporter: sgautherie, Assigned: sgautherie)

References

(Blocks 1 open bug, )

Details

(Keywords: helpwanted, testcase-wanted, Whiteboard: [patchlove][needs updated patch][stuck on comment 10])

Attachments

(3 files, 2 obsolete files)

(Noticed while working on bug 365723 and its duplicates.)
Port
<http://bonsai.mozilla.org/cvslog.cgi?file=/mozilla/mail/extensions/smime/content/msgHdrViewSMIMEOverlay.js&rev=HEAD&mark=1.5>
{{
1.5	scott%scott-macgregor.org	2007-07-14 15:32	 	make me happy, add some removeEventListener calls to match the addEventListener calls in this file.
}}
to SeaMonkey.
Assignee: nobody → sgautherie.bz
Status: NEW → ASSIGNED
Attachment #327068 - Flags: superreview?(neil)
Attachment #327068 - Flags: review?(neil)
Attachment #327068 - Flags: superreview?(neil)
Attachment #327068 - Flags: superreview+
Attachment #327068 - Flags: review?(neil)
Attachment #327068 - Flags: review+
Keywords: checkin-needed
Whiteboard: [c-n: Av1-SM // Leave opened]
Port bug 284369 and bug 380744 to SeaMonkey.
(untested)
Attachment #327096 - Flags: superreview?(neil)
Attachment #327096 - Flags: review?(neil)
Depends on: 284369, 380744
Comment on attachment 327096 [details] [diff] [review]
(Bv1-SM) <msgHdrViewSMIMEOverlay.js>

sr=me on the basis that the Thunderbird code looks like this.
Attachment #327096 - Flags: superreview?(neil)
Attachment #327096 - Flags: superreview+
Attachment #327096 - Flags: review?(neil)
Attachment #327096 - Flags: review?(mnyromyr)
(In reply to comment #3)
> sr=me on the basis that the Thunderbird code looks like this.

Almost: code is copied, format is "fixed" where needed.

*****

Dan, Neil,

I started to port bug 134288 to TB,
but its .xul files miss the statusbars from bug 129100 (I didn't look further).
I guess TB does not want to add them ?

Yet, I was hoping to merge/unfork some/these SM+TB files,
possibly by adding some |if (gSignedStatusPanel)| in JS and some |#if SUITE| in XUL...
Does that seem wanted, or is it "better" to keep them forked ?
Checking in mailnews/extensions/smime/resources/content/msgHdrViewSMIMEOverlay.js;
/cvsroot/mozilla/mailnews/extensions/smime/resources/content/msgHdrViewSMIMEOverlay.js,v  <--  msgHdrViewSMIMEOverlay.js
new revision: 1.14; previous revision: 1.13
done
Keywords: checkin-needed
Comment on attachment 327068 [details] [diff] [review]
(Av1-SM) <msgHdrViewSMIMEOverlay.js>
[Checkin: Comment 5]

"approval‑seamonkey1.1.10/11=?":
Fixes leak of 4 Event Listeners.
Attachment #327068 - Attachment description: (Av1-SM) <msgHdrViewSMIMEOverlay.js> → (Av1-SM) <msgHdrViewSMIMEOverlay.js> [Checkin: Comment 5]
Severity: normal → trivial
Whiteboard: [c-n: Av1-SM // Leave opened]
Whether or not Tb wants the statusbar icons, it *needs* them, since unlike SM it has a collapsed headerpane mode that doesn't show the signed/encrypted icon at all. Unfortunately, Tb doesn't want them to be insertbefore="offline-status", since that's "far left under the threadpane" for Tb, instead of SM's "far right, just like the headerpane icon is."
Blocks: 438562
And if it quells your horror at putting in that block of HTML that will then insert a string full of HTML, bug 438562 is trying to fix the string a bit, though it's blocked by the way suite's string is currently unused.
(In reply to comment #7)
> Tb doesn't want them to be insertbefore="offline-status"
Perhaps we can agree on something to insertafter?
Attached patch (Cv1-TB) <content/*> (obsolete) — Splinter Review
This is the current code, as is.
I think I would need someone to send me a signed message, so I could test (the js) myself.

I tried to have a look with DOMi, but the insertion point seems not to be exactly where I "expected" it and I get exceptions...
Feel free to take over this patch ! (At least, helpwanted.)
Comment on attachment 327096 [details] [diff] [review]
(Bv1-SM) <msgHdrViewSMIMEOverlay.js>

At least this got me motivated to set up my cert stuff. ;-)
Attachment #327096 - Flags: review?(mnyromyr) → review+
Keywords: checkin-needed
Whiteboard: [c-n: Bv1-SM // Leave opened]
The patch doesn't apply cleanly to current trunk. Please update it:

Hunk #4 FAILED at 192.
Keywords: checkin-needed
Bv1-SM, with comment 12 suggestion(s).

(No conflict: "your" cvs seems to have been confused by the new context (after the previous patch/checkin) :-|)
Attachment #327096 - Attachment is obsolete: true
Whiteboard: [c-n: Bv1-SM // Leave opened] → [c-n: Bv1a-SM // Leave opened]
Keywords: checkin-needed
(In reply to comment #13)
> (No conflict: "your" cvs seems to have been confused by the new context (after
> the previous patch/checkin) :-|)

Patch was confused by the changed lines around the bit it was adding. I did not know/want to investigate the consequence of the changes of the other lines on the patch to check in, therefore I flagged it.
Checking in mailnews/extensions/smime/resources/content/msgHdrViewSMIMEOverlay.js;
/cvsroot/mozilla/mailnews/extensions/smime/resources/content/msgHdrViewSMIMEOverlay.js,v  <--  msgHdrViewSMIMEOverlay.js
new revision: 1.15; previous revision: 1.14
done
Keywords: checkin-needed
Attachment #330492 - Attachment description: (Bv1a-SM) <msgHdrViewSMIMEOverlay.js> → (Bv1a-SM) <msgHdrViewSMIMEOverlay.js> [Checkin: Comment 15]
Whiteboard: [c-n: Bv1a-SM // Leave opened]
Product: Core → MailNews Core
Serge, is there anything left in this bug?
Cv1-TB, unbitrotted:
*see comment 10.
*commented out bundle: untested.
Attachment #327357 - Attachment is obsolete: true
Flags: wanted-thunderbird3?
Keywords: helpwanted
No longer blocks: 442838
Flags: wanted-thunderbird3?
Severity: trivial → minor
Whiteboard: [patchlove][needs updated patch]
Keywords: testcase-wanted
Whiteboard: [patchlove][needs updated patch] → [patchlove][needs updated patch][stuck on comment 10]
Removing myslef on all the bugs I'm cced on. Please NI me if you need something on MailNews Core bugs from me.
You need to log in before you can comment on or make changes to this bug.