44223 - Make "Open Link in New Window" first item in context menu

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect, P2)

Description

[Ben Bucksch (:BenB)]

Split-off from bug 38642.

"Open in new window" is a *very* frequent action (I do that for every second
mail), and should be accessible very fast. (On Unix, you might be able to
middle-click, but not everyone can do that.)

Comment 1

[Ben Bucksch (:BenB)]

nsbeta2, 4xp

Comment 2

[scottputterman]

I recommend that this not get an nsbeta2+.  It's a polish issue and nothing 
destructive happens. In the worst case scenario the user will have a standalone 
message window open with the current message in it if they choose the first 
item. Presumably this won't happen after a few times of doing this. I'll agree 
that it's inconvenient for users who are used to this, but the open link in new 
window item is there, just lower down.

Comment 3

[Ben Bucksch (:BenB)]

> It's a polish issue

Agreed. I just want this bug being fixed before a release. I don't care much
*when* this will be done.

Comment 4

[Jay Patel [:jay]]

Putting on [nsbeta2-] radar. Not critical to beta2. 

Comment 5

[scottputterman]

*** Bug 45025 has been marked as a duplicate of this bug. ***

Comment 6

[lchiang]

+ per mail triage

Comment 7

[Jon Granrose]

I'm using 4.7 today since yesterday's M18 is so bad and noticed that I was 
right, the "open link in new window" is the first item on the context menu when 
reading mail in 4.x.  I use this in almost every message.  My personal 
preference is that there should be a pref to be able to have every time I click 
on a link it opens in a new window.  But since I can't, I use open link in new 
window constantly.  It is such a pain to have to remember not to use the first 
one and scroll all the way down to the bottom of the menu to get to the open 
link item.

*please* make sure this gets in before RTM.  Hell, if someone shows me how to 
hack the xul, etc. I'll put it in myself.  It's the little usability items like 
this that make a product a pleasure to use, or not.

Comment 8

[lchiang]

You want to fix this granrose?  :-)
It's been + so hopefuly will get addressed.

Comment 9

[lchiang]

P2 per mail triage

Comment 10

[Jon Granrose]

Been spending even more time in 4.7 this week, decided to look at this.  Just 
moving the menu item is trivial, the harder part is making the menu context 
sensitive so the link (open, edit, copy link) items are at the top only when 
over a link.  Don't know how to do that, but this patch moves the Open Link menu 
item to the top of the menu all the time and puts a separator below it.  Anyone 
can change this in their local copy by doing a find for this file in the 
chrome dir and editing it the same way with a text editor.

Comment 11

[Jon Granrose]

Attachment: diff to move Open Link menu item to top of mail mesg body window menu

Comment 12

[Ben Bucksch (:BenB)]

> the harder part is making the menu context
> sensitive so the link (open, edit, copy link) items are at the top only when
> over a link.

It *is* context sensitive for me (BTW: Isn't that the point of "context menus"?
;) ): "Open Link..." only appears, if over a link.

Comment 13

[Ben Bucksch (:BenB)]

The patch works for me, but I suggest some changes before checkin in:
- Move /all/ context-sensitive (i.e. link-related) items to the top.
- Hide the separator

Comment 14

[scottputterman]

I have a fix for this.  It's basically what granrose did with some other work to 
clean these up a bit.

Comment 15

[scottputterman]

fix checked in.

Comment 16

[Jon Granrose]

suh-weeet!  Thanks, Scott!

Comment 17

[laurel]

OK using aug25 commercial build, linux rh6.0, NT 4.0 and mac OS 9.0