Closed Bug 44234 Opened 24 years ago Closed 24 years ago

When entering a password the password pop-up in mail doesn't close

Categories

(MailNews Core :: Networking, defect, P3)

x86
Windows 98

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: jeziorek, Assigned: mscott)

Details

(Keywords: smoketest, Whiteboard: [dogfood+])

Attachments

(1 file)

-start browser
-Tasks | Mail
-Try and get new messages from an account where it will ask you for a password
-click ok aftert entering in your password and the password pop-up will hang
-its moveable but not closeable
*note: might be a windows 98 problem and may not work on NT
Win32 comm. 2000-06-29-08-M17
Keywords: smoketest
Reassining to Mail->Networking in the hopes that it will catch the eye of someone 
who knows about the mail password dialog.
Assignee: mstoltz → mscott
Component: Security: General → Networking - General
QA Contact: lchiang → laurel
Esther and I are both trying this with today's build for various profiles. She's
on win98, I'm on NT 4.0.

So far Esther hit the problem in Win98 with POP and is now trying IMAP.
I tried IMAP on NT and didn't have the problem, but did with my POP profile.
Does new mail still come in?  Does the dialog stay to the front?  
Severity: normal → major
In my instances the dialog stayed in the front, mail does come in if you gave
the correct password. But if you give an incorrect password, you can't get
another dialog after the incorrect login alert.
In the case of incorrect login, Get Msg won't even cause a new password dialog
to appear, you're still stuck with the password and alert dialogs from the first
try -- neither dialog can be dismissed.  However, you can Quit and the dialog(s)
will go away (no hang or crash or anything).
i wonder if we have the same problems dimissing password dialogs in the browser
nominate dogfood.

This is not the master sign-on password dlg, is it?

Keywords: dogfood
My comments were directed at the mail login, not master sign-on dialog.
Even though this is not the master password, the dialog is being put up by 
single signon so I guess I'm involved here.

On Tuesday I changed an incorrect parameter that mail was using when calling the 
password-prompt dialog.  But if that caused the problem, you would have seen the 
problem on Wednesday's builds.  Did this work correctly on Wednesday?
Is the "save this password" checkbox present in the dialog?
Didn't happen to me yesterday.
Yes, there's a "Use Password Manager to remember this value" checkbox present.
seems similiar (if not the same problem as) bug 44231
*** Bug 44233 has been marked as a duplicate of this bug. ***
This is possibly related to my changes yesterday.  I put in a check to prevent 
events from being passed from frames to content during window destruction as a 
fix for bug 41013.  If anyone has an Win98 build they could change one line in 
nsPresShell.cpp to test this.  I've made a walk around and could find nobody 
with a current win98 build system, so if anyone CC'd here can help, please drop 
me a line (x6821 or pollmann@netscape.com)
Eric, I can test on win98.  What change should I make?  Or should I just back 
out your changes?
Cool, thanks Blake!  I've attached a patch above that can be applied to 
nsPresShell.cpp to disable my change.  This would require a recompile in these 
directories:

mozilla/layout/html/base/src
mozilla/layout/build
Putting on [dogfood+] radar. 
Whiteboard: [dogfood+]
ack...actually, sorry Eric -- I can't test this because of bug 43856 [I can't 
get new mail].  Although, would [should] this also fix the similar Open Web 
Location problem (which I can test)?
Yes, if it is my changes from yesterday that caused the bug, this patch will 
disable them and you should see the bug go away.
Eric, if you think this may be you than can you try this out? If you don't want
to try it in mail, WIN NT shows the same problem in the browser. See Bug #44231.
so you should be able to try it out with your stuff disabled in the browser as
well. Thanks.
mscott, I'm also trying it [building as we speak]
I don't see the problem on NT with my changes in a tree from last night.   I'm 
building an updated tree now.  Hm, this seems to say it's not my changes, but I 
won't be 100% sure until the build finishes and I try again.
I just updated to the tip on NT and don't see this problem anymore.  Robert 
Churchill was kind enough to try on Win98 and is also not seeing the problem 
anymore.  Is this an optimized only problem?
Actually, the afternoon respin does not have this problem. I open mail, 
enter password, click OK, and the dialog window goes away cleanly (win95).

In addition, the three scenarios on bug 44231, also work with the respin
on win95 (checking the respin builds for linux and mac in a moment). 

(Any one have a good theory why bryner's checkin for smoketest blocker bug 
44235 may have cleared this one up too?)
This may have been windows only, but with the 2000062614 comm. builds, the 
password dialog goes away on mac and linux too. [And open web location dialog,
Find in Page dialog, and create new folder name prompt in Bookmarks go away 
as well (bug #44321)]
This works now.  Thanks to Eric, Blake, and John for testing this out.
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Ok for me using jun30 ma7 commercial build linux rh6.0, NT 4.0 and mac OS 9.0
Status: RESOLVED → VERIFIED
Product: MailNews → Core
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: