Use sql_iposition instead of sql_position(lc($var), LOWER($var)) in Bugzilla::User::match

RESOLVED FIXED in Bugzilla 3.4

Status

()

Bugzilla
Database
--
enhancement
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: Max Kanat-Alexander, Assigned: Max Kanat-Alexander)

Tracking

3.1.4
Bugzilla 3.4
Bug Flags:
approval +

Details

Attachments

(1 attachment)

v1
983 bytes, patch
Frédéric Buclin
: review+
Details | Diff | Splinter Review
(Assignee)

Description

9 years ago
In bug 321427 I created sql_iposition, and there are a few other places that we can use it other than the place I used it in that bug.
(Assignee)

Comment 1

9 years ago
Turns out it's only used in Bugzilla::User.
Summary: Use sql_iposition instead of sql_position(lc($var), LOWER($var)) → Use sql_iposition instead of sql_position(lc($var), LOWER($var)) in Bugzilla::User::match
(Assignee)

Comment 2

9 years ago
Created attachment 327346 [details] [diff] [review]
v1

This patch is pretty obvious. This is also the very last use of LOWER in Bugzilla outside of the DB layer! :-) This should make user-matching slightly faster on MySQL, I think.
Assignee: database → mkanat
Status: NEW → ASSIGNED
Attachment #327346 - Flags: review?(LpSolit)

Comment 3

9 years ago
Comment on attachment 327346 [details] [diff] [review]
v1

Works fine. r=LpSolit
Attachment #327346 - Flags: review?(LpSolit) → review+

Updated

9 years ago
Flags: approval+
(Assignee)

Comment 4

9 years ago
Checking in Bugzilla/User.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/User.pm,v  <--  User.pm
new revision: 1.165; previous revision: 1.164
done
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
(Assignee)

Updated

9 years ago
Target Milestone: Bugzilla 4.0 → Bugzilla 3.4
You need to log in before you can comment on or make changes to this bug.