Closed
Bug 442582
Opened 17 years ago
Closed 17 years ago
Use sql_iposition instead of sql_position(lc($var), LOWER($var)) in Bugzilla::User::match
Categories
(Bugzilla :: Database, enhancement)
Tracking
()
RESOLVED
FIXED
Bugzilla 3.4
People
(Reporter: mkanat, Assigned: mkanat)
References
Details
Attachments
(1 file)
|
983 bytes,
patch
|
LpSolit
:
review+
|
Details | Diff | Splinter Review |
In bug 321427 I created sql_iposition, and there are a few other places that we can use it other than the place I used it in that bug.
|
Assignee | |
Comment 1•17 years ago
|
||
Turns out it's only used in Bugzilla::User.
Summary: Use sql_iposition instead of sql_position(lc($var), LOWER($var)) → Use sql_iposition instead of sql_position(lc($var), LOWER($var)) in Bugzilla::User::match
|
|
Assignee | |
Comment 2•17 years ago
|
||
This patch is pretty obvious. This is also the very last use of LOWER in Bugzilla outside of the DB layer! :-) This should make user-matching slightly faster on MySQL, I think.
|
|
||
Comment 3•17 years ago
|
||
Comment on attachment 327346 [details] [diff] [review]
v1
Works fine. r=LpSolit
Attachment #327346 -
Flags: review?(LpSolit) → review+
|
|
||
Updated•17 years ago
|
Flags: approval+
|
|
Assignee | |
Comment 4•17 years ago
|
||
Checking in Bugzilla/User.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/User.pm,v <-- User.pm
new revision: 1.165; previous revision: 1.164
done
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•17 years ago
|
Target Milestone: Bugzilla 4.0 → Bugzilla 3.4
You need to log in
before you can comment on or make changes to this bug.
Description
•