442711 - Tab sync not displaying all virtual tabs

Status: RESOLVED FIXED

(Cloud Services :: General, defect)

Description

[Dan Mills [:thunder]]

Attachment: Virtual tabs json file

I get an empty notification popup (with the tab sync notification, but no entries in it).  In my 'tabs from other computers' menu, I see two listed:

Mozilla Firefox Start Page
2loglines (4 unread, 12 pinned)

I'm attaching my virtual tabs file.

Comment 1

[Myk Melez [:myk] [@mykmelez]]

Looking at this...

Comment 2

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch v1: fixes problem

Here's a patch that fixes the problem.  Before I check it in, I want to test what happens if we apply this validation step on command creation/editing rather than only at display time.

Comment 3

[Myk Melez [:myk] [@mykmelez]]

changeset:   844:c6c4a13cc763
tag:         tip
date:        Mon Jun 30 15:13:07 2008 -0700
summary:     bug 442711: validate virtual tabs to make sure they have the minimal information necessary to recreate them before trying to save them or notify the user about them

Fixed with an updated patch that logs a warning and doesn't do anything when _createCommand or _editCommand is called for an invalid tab (one that doesn't contain the minimum amount of information necessary to recreate the tab).

Note that I left in the code that validates tabs when the Tabs From Other Computers menu and notification are displayed, which is redundant.  Hmm, maybe I should remove that redundancy.

Comment 4

[Myk Melez [:myk] [@mykmelez]]

Note: I think Firefox bug 366509 is what caused the data to get into the corrupted state that triggered this bug.

The fix for this bug obviously doesn't address that problem but should work around it to the degree possible (i.e. if corruption occurs when tabs are synced from client A to the server, the corrupted tab won't be added to the virtual tabs on client B, so it'll get removed from the server the next time client B syncs).