442801 - No caret or wrongly positioned caret within contenteditable=inherit element

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect)

Description

[Martijn Wargers (dead)]

Attachment: testcase

See testcase, click somewhere in the text and start typing.

A lot of times, I just don't get a caret and when I get a caret, its position doesn't change when typing.

Comment 1

[arno renevier]

In you click, you don't get a caret *immediately* but if you wait a few seconds, caret will start blinking. Also, when typing something, caret is not *immediately* deplaced. But if wait blinking, caret will move to the right place.

It's because in inner div style "mUserModify" is set to read-only. So, when calling nsCaret::DrawAtPositionWithHint after text has been inserted, caret position will not be updated[1].

usermodify property is set to read-only on inner div in nsGenericHTMLElement::MapCommonAttributesInto because contenteditable attribute is neither empty, neither "true" [2], but according to spec[3] it should be set to read-write if attribute true or empty, read-only if attribute is false, and it should search for a parent with contenteditable attribute in other cases.

[1]: http://mxr.mozilla.org/mozilla/source/layout/base/nsCaret.cpp#607
[2]: http://mxr.mozilla.org/mozilla/source/content/html/content/src/nsGenericHTMLElement.cpp#1894
[3]: http://www.whatwg.org/specs/web-apps/current-work/#contenteditable

Comment 2

[arno renevier]

Attachment: patch v1

Comment 3

[Peter Van der Beken [:peterv]]

Comment on attachment 341743 [details] [diff] [review]
patch v1

>diff -r 184ad4f909cd content/html/content/src/nsGenericHTMLElement.cpp

>-        }
>-        else {
>-          ui->mUserModify.SetIntValue(NS_STYLE_USER_MODIFY_READ_ONLY,
>-                                      eCSSUnit_Enumerated);
>+        } else if (value->Equals(nsGkAtoms::_false, eIgnoreCase)) {

Keep the else on its own line.

Comment 4

[arno renevier]

Attachment: patch v1.1 [Checkin: Comment 5]

same patch with "else" on its own line (addressing peterv comment)

Comment 5

[Serge Gautherie (:sgautherie)]

Comment on attachment 341911 [details] [diff] [review]
patch v1.1
[Checkin: Comment 5]

http://hg.mozilla.org/mozilla-central/rev/fb32055b742a