Closed Bug 442830 Opened 16 years ago Closed 16 years ago

modules/distribution.js: int and bool prefs are not set correctly

Categories

(Firefox :: General, defect)

Product:
Firefox
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 3.1a1

People

(Reporter: u217243, Assigned: u217243)

Details

(Keywords: verified1.9.0.2)

Attachments

(1 file)

fix
1.19 KB, patch
hello
: review+
benjamin
: review+
mconnor
: approval1.9.0.2+
Details | Diff | Splinter Review
Attached patch fix — — Splinter Review 
I have tested a partner build and found that integer and boolean prefs specified in the distribution.ini are not set correctly. Here's the patch.
Component: Release Engineering → General
Product: mozilla.org → Firefox
QA Contact: release → general
Version: other → Trunk
Dan, could you please review Kohei's patch? Apologies, I thought you were on this bug.
Attachment #327527 - Flags: review?(thunder)
Assignee: thunder → yoshino
Comment on attachment 327527 [details] [diff] [review]
fix

bsmedberg is probably a more legal reviewer for this.
Attachment #327527 - Flags: review?(benjamin)
dan wrote it, I would like him to review the changes, then I'll ask for a formal review.
ダンさん、レビューお願いします。
Comment on attachment 327527 [details] [diff] [review]
fix

Oops.  Yes, looks good.
Attachment #327527 - Flags: review?(thunder) → review+
(In reply to comment #4)
> ダンさん、レビューお願いします。

パッチをありがとうございます！　:-)
I don't have a CVS commit privilege, so please checkin my patch along with an another patch in Bug 436540. よろしくお願いします :)
Attachment #327527 - Flags: review?(benjamin) → review+
Flags: blocking1.9.0.2+
Attachment #327527 - Flags: approval1.9.0.2+
Keywords: checkin-needed
CVS HEAD (1.9.0 branch):

Checking in browser/components/distribution.js;
/cvsroot/mozilla/browser/components/distribution.js,v  <--  distribution.js
new revision: 1.2; previous revision: 1.1
done
Status: NEW → RESOLVED
Closed: 16 years ago
Keywords: checkin-needed → fixed1.9.0.2
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.1a1
Verified fix on Mozilla/5.0 (Windows; U; Windows NT 5.1; ja-JP-mac; rv:1.9.0.2pre) Gecko/2008080705 GranParadiso/3.0.2pre.   The code changes are shown in distribution.js
Status: RESOLVED → VERIFIED
Keywords: fixed1.9.0.2 → verified1.9.0.2
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: