Closed Bug 442874 Opened 16 years ago Closed 16 years ago

Remove some unnecessary force overrides in mail/base/jar.mn

Categories

(Thunderbird :: Build Config, defect)

defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3

People

(Reporter: standard8, Assigned: standard8)

Details

Attachments

(1 file)

Attached patch The fixSplinter Review
In mail/base/jar.mn on the communicator files, we have two flags set, one for preprocessing (*), the second for forcing-override of already included files (+).

As we no longer build xpfe/communicator these days, the force-override is unnecessary. Unfortunately the build still seems to regenerate those files each time because of the preprocessing, but its a flag that doesn't need to be there and we should just drop it.
Attachment #327573 - Flags: review?(philringnalda)
Comment on attachment 327573 [details] [diff] [review]
The fix

Yep. I was going to say that "*+" is always wrong, but I guess it has a little meaning, if you're worried that someone will stop preprocessing and not realize they need to change from * to + when they do.
Attachment #327573 - Flags: review?(philringnalda) → review+
Patch checked in -> fixed.
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: