442985 - Weave FirstRun Wizard "Set Up Another Computer" screen overwrites saved username/passwords, without clicking "next"

Status: RESOLVED DUPLICATE of bug 442981

(Cloud Services :: General, defect, P3)

Description

[Daniel Holbert [:dholbert]]

Steps to reproduce:
 1. Install Weave 0.2.0, making sure to tell it to save your username & password & passphrase.
 2. Click the Weave status icon, and select "sign out".
 3. Click the Weave status icon, and select Preferences
 5. Click "Create Account"
 6. Click through the license agreement
 7. Click "Set up Another Computer"
 8. Type in username: "abc" and password: "x".  (note that it doesn't verify)
 9. Click 'Cancel'
 10. Click the Weave status icon, and select "Sign In"

ACTUAL RESULTS:
 My saved username / password are gone, and have been replaced with the bogus information entered in step 8.

EXPECTED RESULTS:
 Saved username / password should not be overwritten until the user has completed the wizard. (or at the very least, they shouldn't be overwritten until the user clicks "Next" on the account verification.)

Comment 1

[Daniel Holbert [:dholbert]]

VERSION INFO:
 * Weave 0.2.0
 * Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.1pre) Gecko/2008061804
GranParadiso/3.0.1pre
 * Ubuntu Linux 8.04

Comment 2

[Daniel Holbert [:dholbert]]

IMHO this is a pretty major issue -- upping severity.

Comment 3

[Daniel Holbert [:dholbert]]

(In reply to comment #0)
> EXPECTED RESULTS:
>  Saved username / password should not be overwritten until the user has
> completed the wizard.

FWIW, I think the "Create New User" wizard doesn't commit the new username / passwords until the very final step is completed.  (At least, that's the first time *it* prompts me for my master password.)

Following the Principle of Least Surprise, I think the "Use Existing Account" wizard should mirror that behavior.  (This is the reasoning behind the "expected results" from comment 0)

Comment 4

[Dan Mills [:thunder]]

This is really the same problem as 442981.