Closed Bug 443001 Opened 16 years ago Closed 16 years ago

String concatenation results in extensive recursion

Categories

(Tamarin Graveyard :: Tracing Virtual Machine, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: rob.borcic, Assigned: daumling)

Details

The implementation of String::collectTree is highly recursive. Running the ecma3/Array/e15_4_2_1_2.as testcase recurses into collectTree to a depth of 2043. This is exacerbated by an apparent problem in string concatenation that fails to save the tree depth. String::concatStrings() calls String::getDepth() to test if the string should be flattened, but String::setDepth() is never called.
Assignee: nobody → daumling
I am working on a non-recursive version.
Status: NEW → ASSIGNED
Patch attached to bug #411163.
The patch does allow the ecma3/Array/e15_4_2_1_2.as testcase to run to completion on Symbian.
So I guess that we can view this bug as fixed.
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.