Closed Bug 443083 Opened 16 years ago Closed 16 years ago

OSX system proxy settings not enabled in release builds

Categories

(Core :: Networking, defect)

Product:
Core
Component:
Networking
Platform:
All
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla1.9.1a1

People

(Reporter: jamesbunton, Assigned: jamesbunton)

References

Details

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X 10.5; en-US; rv:1.9.1a1pre) Gecko/2008070204 Minefield/3.1a1pre
Build Identifier: 

As a result of bug 125995, attachment 314082 [details] [diff] [review] was applied to trunk. This contained all the code for Mozilla to obtain system proxy settings from Mac OS X.

However there were two small changes missing from that patch which are needed to enable the functionality fully. These are:
 * Add OSXPROXY_MODULE to nsStaticXULComponents.cpp
 * Enable the "Use system proxy" option in the UI


Reproducible: Always
The patches that need to be applied are:
 * Attachment 327637 [details] [diff]
 * Attachment 313572 [details] [diff]
Flags: wanted1.9.1?
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: checkin-needed
Attachment 327637 [details] [diff] is still in the review queue. So nothing to check-in for the moment.
Assignee: nobody → jamesbunton
Blocks: 125995
Keywords: checkin-needed
Hardware: Macintosh → All
Version: unspecified → Trunk
> Attachment 327637 [details] [diff] pushed in 15865:e0b988b411cd.
Status: NEW → RESOLVED
Closed: 16 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1a1
System proxy settings are selectable now. Verified with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1a1pre) Gecko/2008071302 Minefield/3.1a1pre ID:2008071302
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.