443157 - task invitation leads to exceptions on startup

Status: VERIFIED FIXED

(Calendar :: General, defect)

Description

[Andreas Treumann]

STEPS TO REPRODUCE:
===================

- create an event with an attendee on your for e.g. wcap calendar
- convert this event to a task

RESULT:
=======

- the attendee gets exceptions in the error console at startup/refresh and when he opens the invitations dialog.

Output:

Error: item.startDate has no properties
Source File: chrome://calendar/content/calendar-invitations-manager.js
Line: 328

Error: [context-id: 85285de3-784e-4a25-8ebd-7d6d64977d79, uri: http://chagall/, userId=at93795, default calendar]
error: [Exception... "'[JavaScript Error: "item.startDate has no properties" {file: "chrome://calendar/content/calendar-invitations-manager.js" line: 328}]' when calling method: [calIOperationListener::onGetResult]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame :: file:///C:/Documents%20and%20Settings/at93795/Application%20Data/Thunderbird/Profiles/bigaf98i.default2/extensions/%7Be2fda1a4-762b-4020-b5ad-a41df1933103%7D/js/calWcapCalendarItems.js :: netResp :: line 1315"  data: yes]
stack:
1: [file:///C:/Documents%20and%20Settings/at93795/Application%20Data/Thunderbird/Profiles/bigaf98i.default2/extensions/%7Be2fda1a4-762b-4020-b5ad-a41df1933103%7D/js/calWcapUtils.js:167] logError
2: [file:///C:/Documents%20and%20Settings/at93795/Application%20Data/Thunderbird/Profiles/bigaf98i.default2/extensions/%7Be2fda1a4-762b-4020-b5ad-a41df1933103%7D/js/calWcapCalendar.js:71] calWcapCalendar_notifyError_
3: [file:///C:/Documents%20and%20Settings/at93795/Application%20Data/Thunderbird/Profiles/bigaf98i.default2/extensions/%7Be2fda1a4-762b-4020-b5ad-a41df1933103%7D/js/calWcapCalendar.js:88] calWcapCalendar_notifyError
4: [file:///C:/Documents%20and%20Settings/at93795/Application%20Data/Thunderbird/Profiles/bigaf98i.default2/extensions/%7Be2fda1a4-762b-4020-b5ad-a41df1933103%7D/js/calProviderBase.js:176] cPB_notifyOperationComplete
5: [file:///C:/Documents%20and%20Settings/at93795/Application%20Data/Thunderbird/Profiles/bigaf98i.default2/extensions/%7Be2fda1a4-762b-4020-b5ad-a41df1933103%7D/js/calWcapCalendarItems.js:1173] getItems_resp
6: [file:///C:/Documents%20and%20Settings/at93795/Application%20Data/Thunderbird/Profiles/bigaf98i.default2/extensions/%7Be2fda1a4-762b-4020-b5ad-a41df1933103%7D/js/calWcapRequest.js:181] calWcapRequest_execRespFunc
7: [file:///C:/Documents%20and%20Settings/at93795/Application%20Data/Thunderbird/Profiles/bigaf98i.default2/extensions/%7Be2fda1a4-762b-4020-b5ad-a41df1933103%7D/js/calWcapRequest.js:196] calWcapRequest_execSubRespFunc
8: [file:///C:/Documents%20and%20Settings/at93795/Application%20Data/Thunderbird/Profiles/bigaf98i.default2/extensions/%7Be2fda1a4-762b-4020-b5ad-a41df1933103%7D/js/calWcapSession.js:723] issueNetworkRequest_resp
9: [file:///C:/Documents%20and%20Settings/at93795/Application%20Data/Thunderbird/Profiles/bigaf98i.default2/extensions/%7Be2fda1a4-762b-4020-b5ad-a41df1933103%7D/js/calWcapRequest.js:194] calWcapRequest_execSubRespFunc
10: [file:///C:/Documents%20and%20Settings/at93795/Application%20Data/Thunderbird/Profiles/bigaf98i.default2/extensions/%7Be2fda1a4-762b-4020-b5ad-a41df1933103%7D/js/calWcapSession.js:749] netResp

Source File: file:///C:/Documents%20and%20Settings/at93795/Application%20Data/Thunderbird/Profiles/bigaf98i.default2/extensions/%7Be2fda1a4-762b-4020-b5ad-a41df1933103%7D/js/calWcapUtils.js
Line: 167

Error: [context-id: 85285de3-784e-4a25-8ebd-7d6d64977d79, uri: http://chagall/, userId=at93795, default calendar]
error: READ_FAILED
stack:
1: [file:///C:/Documents%20and%20Settings/at93795/Application%20Data/Thunderbird/Profiles/bigaf98i.default2/extensions/%7Be2fda1a4-762b-4020-b5ad-a41df1933103%7D/js/calWcapUtils.js:167] logError
2: [file:///C:/Documents%20and%20Settings/at93795/Application%20Data/Thunderbird/Profiles/bigaf98i.default2/extensions/%7Be2fda1a4-762b-4020-b5ad-a41df1933103%7D/js/calWcapCalendar.js:71] calWcapCalendar_notifyError_
3: [file:///C:/Documents%20and%20Settings/at93795/Application%20Data/Thunderbird/Profiles/bigaf98i.default2/extensions/%7Be2fda1a4-762b-4020-b5ad-a41df1933103%7D/js/calWcapCalendar.js:88] calWcapCalendar_notifyError
4: [file:///C:/Documents%20and%20Settings/at93795/Application%20Data/Thunderbird/Profiles/bigaf98i.default2/extensions/%7Be2fda1a4-762b-4020-b5ad-a41df1933103%7D/js/calProviderBase.js:183] cPB_notifyOperationComplete
5: [file:///C:/Documents%20and%20Settings/at93795/Application%20Data/Thunderbird/Profiles/bigaf98i.default2/extensions/%7Be2fda1a4-762b-4020-b5ad-a41df1933103%7D/js/calWcapCalendarItems.js:1173] getItems_resp
6: [file:///C:/Documents%20and%20Settings/at93795/Application%20Data/Thunderbird/Profiles/bigaf98i.default2/extensions/%7Be2fda1a4-762b-4020-b5ad-a41df1933103%7D/js/calWcapRequest.js:181] calWcapRequest_execRespFunc
7: [file:///C:/Documents%20and%20Settings/at93795/Application%20Data/Thunderbird/Profiles/bigaf98i.default2/extensions/%7Be2fda1a4-762b-4020-b5ad-a41df1933103%7D/js/calWcapRequest.js:196] calWcapRequest_execSubRespFunc
8: [file:///C:/Documents%20and%20Settings/at93795/Application%20Data/Thunderbird/Profiles/bigaf98i.default2/extensions/%7Be2fda1a4-762b-4020-b5ad-a41df1933103%7D/js/calWcapSession.js:723] issueNetworkRequest_resp
9: [file:///C:/Documents%20and%20Settings/at93795/Application%20Data/Thunderbird/Profiles/bigaf98i.default2/extensions/%7Be2fda1a4-762b-4020-b5ad-a41df1933103%7D/js/calWcapRequest.js:194] calWcapRequest_execSubRespFunc
10: [file:///C:/Documents%20and%20Settings/at93795/Application%20Data/Thunderbird/Profiles/bigaf98i.default2/extensions/%7Be2fda1a4-762b-4020-b5ad-a41df1933103%7D/js/calWcapSession.js:749] netResp

Source File: file:///C:/Documents%20and%20Settings/at93795/Application%20Data/Thunderbird/Profiles/bigaf98i.default2/extensions/%7Be2fda1a4-762b-4020-b5ad-a41df1933103%7D/js/calWcapUtils.js
Line: 167

EXPECTED RESULT:
================

- no exceptions

REPRODUCIBLE:
=============

- always

Comment 1

[Berend Cornelius]

Attachment: patch v. #1

tasks are not considered in the invitations-manager

Comment 2

[Philipp Kewisch [:Fallen][📱📆]]

Comment on attachment 327800 [details] [diff] [review]
patch v. #1


>     validateItem: function IM_validateItem(item) {
>         var participationStatus = this.getParticipationStatus(item);
>+        var start = item.startDate || item.entryDate;
var start = item[calGetStartDateProp(item)];

What happens if this is a task without a start date but with a due date? Maybe we need something like 

var start = item[calGetStartDateProp(item)] || item[calGetEndDateProp(item)];

here.

r=philipp with comments considered.

Comment 3

[Berend Cornelius]

checked in the patch with Philipp's comment worked in.
->fixed

Comment 4

[Andreas Treumann]

I checked this issue again with all possible task start/due date combination. The invitations dialog shows only the 'Updating list of invitations' message and the update process doesn't stops. 

Comment 5

[Martin Schröder [:mschroeder]]

(In reply to comment #4)
> I checked this issue again with all possible task start/due date combination.
> The invitations dialog shows only the 'Updating list of invitations' message
> and the update process doesn't stops. 

Andreas: You should file a new bug report. Resolving as INCOMPLETE isn't the right solution.

Comment 6

[Andreas Treumann]

Checked in nightly build 20082919 -> VERIFIED