Closed Bug 443220 Opened 12 years ago Closed 12 years ago
check-one and check-interactive cannot run tests not in a unit/ directory
check-one and check-interactive cannot run tests not in a unit/ directory which makes testing things that live in, say, bookmarks/ really hard to run interactively.
Whoops, that's definitely me. Current thinking is to allow the user to specify a relative path (SOLO_FILE=foo/test_bar.js), and if there are no slashes in the path, assume unit/filename. I can probably do this at the same time as bug 384339.
Assignee: nobody → ajvincent
Attachment #328193 - Flags: review?(rcampbell)
Note: I haven't actually tested this patch by running check-interactive. I tested the code I added by writing a separate shell script and making it work, then copying the code in here. For the rest of it, I simply replaced "unit/" with "$target_dir/". So I'd appreciate having someone test it with a non-unit directory. :)
Attachment #328193 - Flags: review?(rcampbell) → review?(sdwilsh)
Shawn, do you mind reviewing this? I think you're a better review candidate than I am at this point.
(In reply to comment #4) > Shawn, do you mind reviewing this? I think you're a better review candidate > than I am at this point. My shell-script-fu is very very bad. I don't think that'd be wise.
I can review, I think I'm ostensibly the module owner of this stuff.
Comment on attachment 328193 [details] [diff] [review] patch, v1 Since you volunteered... :)
Attachment #328193 - Flags: review?(sdwilsh) → review?(ted.mielczarek)
Comment on attachment 328193 [details] [diff] [review] patch, v1 Wow, we should totally rewrite this in Python.
Attachment #328193 - Flags: review?(ted.mielczarek) → review+
I don't know Python. :(
It sure beats shell, and isn't far from JS.
(In reply to comment #9) > I don't know Python. :( Great time to learn! But it's not pressing as this stuff already works, and yeah, I'm not a fan of non-trivial shell scripts.
I just filed bug 444177 for rewriting test_one.sh in Python.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
backed out due to: 198 src $ expr index "foo.js" "/" expr: syntax error on mac
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Many thanks to irc.freenode.net/#bash for helping me find a more efficient way to get the directory.
Attachment #328631 - Flags: review?(ted.mielczarek) → review+
Let's try this again.
Pushed to mozilla-central: http://hg.mozilla.org/index.cgi/mozilla-central/rev/fef7df33d4aa
Status: REOPENED → RESOLVED
Closed: 12 years ago → 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.