443230 - sort by order received numbering becomes negative if mail folder is large

Status: RESOLVED DUPLICATE of bug 450991

(Thunderbird :: Mail Window Front End, defect)

Description

[Rusty J]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.9) Gecko/2008052906 Firefox/3.0
Build Identifier: version 3.0a2pre (2008070205)

When viewing the list of mail in a folder, if there are a lot of messages in that folder, the order received number becomes negative.  For example, the last four numbers in my order received column are:
2147392257
2147401202
-2147126995
-2147092102

Reproducible: Always

Steps to Reproduce:
1. Sort by order received
2.
3.
Actual Results:  
negative numbers appeared in the order received column.  Crashes release 2 builds.  Doesn't crash latest beta.

Expected Results:  
positive numbers should appear

Comment 1

[WADA:World Anti-bad-Duping Agency]

(1) Negative "Order Received" for mail offset grater than 2147483649(==2**31-1)
Confirmed with Tb 2.0.0.14 & Tb latest trunk(on MS Win XP-SP2), with local mail folder file(size = 2,322,105,618 bytes).

Offset is held in 32bit unsigned integer when Tb on MS Win.
(but is still held in 32 bit signed integer when Linux/Mac OS X)
"Order Received" display seems to still treat the offset as signed integer.
I couldn't see problem other than "negative order received" display. 
=> Confirming

(2) "Crash with Tb 2 release build" part
Unable to produce crash with Tb 2.0.0.14(stadard Theme. no additional extension)
I think your "Crashes release 2 builds" is caused by extension(s).
Can you re-produce Crash with -safe-mode of Tb 2?

Comment 2

[Wayne Mery (:wsmwk)]

bienvenu, could this be resolved as part of the assault on big folder/>2gb issues?

Comment 3

[David :Bienvenu]

(In reply to comment #2)
> bienvenu, could this be resolved as part of the assault on big folder/>2gb
> issues?

The code looks OK, in that we're converting the msg key to a 64 bit int before trying to make it a string, as long as the string routines are doing the right thing.

http://mxr.mozilla.org/comm-central/source/mailnews/base/src/nsMsgDBView.cpp#1942

Comment 4

[Wayne Mery (:wsmwk)]

Thanks david. agree. per hg blame, keyString.AppendInt((PRInt64)key); fixed in Bug 450991 TB20018 2008-10-20 and trunk Oct 15 00:30:19 2008. This fits correctly with Rusty's version and time of report.  (after I hit save it occurred to me this might have already been fixed) 

Rusty, you should be able confirm all is well. :)