443296 - morkRowCellCursor::NextCell skips first cell

Status: RESOLVED FIXED

(MailNews Core :: Database, defect)

Description

[Joshua Cranmer [:jcranmer]]

Attachment: Patch to fix the problem

Small change for a small problem.

In short: NextCell starts by incrementing the current column position, which it does if the column is >= 0. It then grabs the cell of the incremented position.

The column position is initialized to 0, which means that the first call increments to 1, grabbing the second cell.

Comment 1

[Joshua Cranmer [:jcranmer]]

Attachment: Real fix, suggested via IRC

Comment 2

[David :Bienvenu]

Comment on attachment 327895 [details] [diff] [review]
Real fix, suggested via IRC

thx, Joshua.

Comment 3

[Joshua Cranmer [:jcranmer]]

Checking in db/mork/src/morkRow.cpp;
/cvsroot/mozilla/db/mork/src/morkRow.cpp,v  <--  morkRow.cpp
new revision: 1.20; previous revision: 1.19
done

Comment 4

[Joshua Cranmer [:jcranmer]]

Checked into mozilla-central: revision 6be6b3fe30c5.