Closed Bug 443398 Opened 14 years ago Closed 14 years ago

Fix remaining parts of unofficial branding

Categories

(Thunderbird :: Build Config, defect)

All
macOS
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED
Thunderbird 3

People

(Reporter: standard8, Assigned: standard8)

References

Details

Attachments

(3 files, 1 obsolete file)

I've spun this out of bug 397621. To get this all working correctly, we need to:

- Change the ProductName from "Thunderbird" to "Shredder" in mac's tinder-config.pl
- Change the MOZ_APP_DISPLAYNAME in mail/branding/nightly/configure.sh back to "Shredder" (I changed it to Thunderbird to fix bustage).
- Revert the change to mail/app/Makefile.in to match attachment 327867 [details] [diff] [review].

The first item I had r=reed over irc from. The last two I'll just revert it back, as they were already reviewed in bug 397621.

We also need to fix the Sunbird tinderboxes as well.

This all depends on getting bug 443397 fixed as we need the tinderboxes to be updating themselves.
This is the correct patch for setting the correct changes. The tinder-config.pl bit is r=reed (over irc). The rest is r=davida,bienvenu as per the original bug.
Attachment #327946 - Attachment is obsolete: true
Comment on attachment 327947 [details] [diff] [review]
[checked in] Lightning tinder-config.pl fix.

it's the lightning tinder-config.pl. sunbird shouldn't change to "shredder"
iirc, updating tinder-config.pl should work on that box.
Attachment #327947 - Flags: review+
OS: Mac OS X → All
Hardware: PC → All
L10n builds still use Mozilla Thunderbird branding.
Attachment #327947 - Attachment description: Sunbird tinder-config.pl fix. → Lightning tinder-config.pl fix.
Attachment #327947 - Flags: review?(ause)
Henrik unless you know otherwise, I believe this only affects Mac.

(In reply to comment #5)
> L10n builds still use Mozilla Thunderbird branding.

I'll look at fixing that in the next couple of days.
OS: All → Mac OS X
Hardware: All → Macintosh
Indeed. It was a slip on my side that I changed OS to all. But Platform All is still valid.
Hardware: Macintosh → All
This is now checked in, although the lightning mac box needs a Clobber (semi-automatic clobber isn't working...), I'm going to mark this fixed, I'll cover the l10n builds in a separate bug.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3
Mark, what about the user agent string? There is Thunderbird still visible:

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.0.2pre) Gecko/2008071703 Thunderbird/3.0a2pre ID:2008071703

Or was your check-in too late for today's nightly build?
Sorry Mark, that I have to reopen the bug. But the user agent still contains Thunderbird. It should also show Shredder like it's done for Gran Paradiso/Minefield.

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.0.2pre) Gecko/2008071803 Thunderbird/3.0a2pre ID:2008071803
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
This fixes the user-agent in the same manner that Firefox does it. I've changed to @...@ notation and filter substitution as I think its slightly nicer than the expand way.
Attachment #330483 - Flags: review?(bienvenu)
Attachment #327947 - Attachment description: Lightning tinder-config.pl fix. → [checked in] Lightning tinder-config.pl fix.
Attachment #330483 - Flags: review?(bienvenu) → review+
Attachment #328150 - Attachment description: Patch to revert/put back the changes. → [checked in] Patch to revert/put back the changes.
Attachment #330483 - Attachment description: Adjust the user agent for unofficial builds → [checked in] Adjust the user agent for unofficial builds
Should be fixed now. Let's deal with any other issues in separate bugs please.
Status: REOPENED → RESOLVED
Closed: 14 years ago14 years ago
Resolution: --- → FIXED
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1a2pre) Gecko/2008072900 Shredder/3.0a2pre ID:2008072900

Looks wonderful. Verified with the above copy of the user agent.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.