443529 - Turn "running past end" assertions in nsLineBox.h into aborts

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Jesse Ruderman]

Attachment: patch

The "running past end" assertion is usually followed by random crashes due to heap corruption.  These crashes distract me, and I imagine they confuse developers into trying to debug the wrong part of the code.  Making debug builds abort instead of assert will get rid of those distractions and make it more likely for the bugs to get noticed and fixed.

This change only affects debug builds, and takes advantage of the recent change to make NS_ABORT_IF_FALSE work correctly (bug 429930).  I have been surfing the Web for several months with debug builds that include this change, and it hasn't caused any problems for me.

Bugs that have triggered the assertion include:

https://bugzilla.mozilla.org/buglist.cgi?bug_id=310879,355426,376419,386812,395450,397007,400057,404146,411870,423098,443528

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 328081 [details] [diff] [review]
patch

r+sr=dbaron

Comment 2

[Mats Palmgren (inactive)]

Looks like this was checked in:
http://hg.mozilla.org/mozilla-central/index.cgi/rev/5bf203527a02