443734 - Remove initBookmarksToolbar

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P3)

Description

[Asaf Romano (gone)]

Attachment: patch

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 328218 [details] [diff] [review]
patch

>--- a/browser/base/content/browser-menubar.inc
>+++ b/browser/base/content/browser-menubar.inc

>+                   place="place:folder=TOOLBAR&expandQueries=1"

>--- a/browser/base/content/browser.xul
>+++ b/browser/base/content/browser.xul

>+               place="place:folder=TOOLBAR&expandQueries=1"

expandQueries=1 is the default, so they aren't needed afaict. Looks fine otherwise.

Comment 2

[Asaf Romano (gone)]

changeset: 5ca314b18c66.

Comment 3

[Stephen Walker]

It looks like this broke expanding the bookmarks toolbar for a restored session when the bookmarks toolbar is placed on the menubar.

[menu][bookmarkstoolbar][unifiedbackforward][stop][reload][urlbar][searchbar]
is now shown as 
[menu][overflow expander(>>)][unifiedbackforward][stop][reload][urlbar][searchbar]

Opening the customize toolbar dialog window is a workaround for now since closing the dialog window forces the bookmarks toolbar to expand.

Comment 4

[Mathieu Johnson]

It's broke for a new session too, not just a restored one. (When the toolbar is on the menubar)

Comment 5

[Asaf Romano (gone)]

Open a new bug please.

Comment 6

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv