Closed
Bug 443768
Opened 17 years ago
Closed 17 years ago
[WinCE] Several conditions in mode2binstr are always true
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jruderman, Unassigned)
References
Details
Attachments
(1 file)
|
2.03 KB,
patch
|
dougt
:
review+
|
Details | Diff | Splinter Review |
The reporter of bug 440771 points out that these conditions are always true:
build/wince/shunt/stdio.cpp:215 if (mode | O_RDWR ||
(mode | O_WRONLY)) // write only == read|write
build/wince/shunt/stdio.cpp:217 if (mode | O_CREAT)
build/wince/shunt/stdio.cpp:221 else if (mode |
O_APPEND)
build/wince/shunt/stdio.cpp:225 else if (mode |
O_TRUNC)
build/wince/shunt/stdio.cpp:235 else if (mode |
O_RDONLY)
Are all those "|" operators supposed to be "&"?
|
Reporter | |
Updated•17 years ago
|
Blocks: InspectTool
|
||
Comment 1•17 years ago
|
||
|
||
Comment 2•17 years ago
|
||
Comment on attachment 329468 [details] [diff] [review]
Patch to fix the Using | instead of & bugs inside mode2binstr
this is fine. in the future use unified diff. it makes reviewing a bunch easier (diff -u10).
Attachment #329468 -
Flags: review+
|
|
||
Comment 3•17 years ago
|
||
changeset: 15933:b084662e3b0f
tag: tip
user: Doug Turner <dougt@meer.net>
date: Mon Jul 14 09:30:52 2008 -0700
summary: Bug 443768. Several conditions in mode2binstr are always true. patch=wolfe@lobo.us, r=dougt@meer.net
thanks for the patch wolfe.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
|
||
Updated•8 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•