Closed Bug 443768 Opened 14 years ago Closed 14 years ago
CE] Several conditions in mode2binstr are always true
The reporter of bug 440771 points out that these conditions are always true: build/wince/shunt/stdio.cpp:215 if (mode | O_RDWR || (mode | O_WRONLY)) // write only == read|write build/wince/shunt/stdio.cpp:217 if (mode | O_CREAT) build/wince/shunt/stdio.cpp:221 else if (mode | O_APPEND) build/wince/shunt/stdio.cpp:225 else if (mode | O_TRUNC) build/wince/shunt/stdio.cpp:235 else if (mode | O_RDONLY) Are all those "|" operators supposed to be "&"?
Comment on attachment 329468 [details] [diff] [review] Patch to fix the Using | instead of & bugs inside mode2binstr this is fine. in the future use unified diff. it makes reviewing a bunch easier (diff -u10).
Attachment #329468 - Flags: review+
changeset: 15933:b084662e3b0f tag: tip user: Doug Turner <email@example.com> date: Mon Jul 14 09:30:52 2008 -0700 summary: Bug 443768. Several conditions in mode2binstr are always true. firstname.lastname@example.org, email@example.com thanks for the patch wolfe.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.