443893 - [2.x only] No twisty shown for multiple mail addresses while there should be one

Status: NEW

(Thunderbird :: Message Reader UI, defect)

Description

[xzoli]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-GB; rv:1.8.1.15) Gecko/20080623 Firefox/2.0.0.15
Build Identifier: Thunderbird version 2.0.0.14 (20080421)

When I receive a mail that has many adressees in the To: field, then in many cases the "+" box to show all the recipients is not shown. Only a few (1 or 2) mail addresses are shown, with the "," at the end suggesting that there are more.

The "All headers" button doesn't help either.

This bug was introduced with 2.0.0.14.
This happens with most mails every time.


Reproducible: Always

Comment 1

[Joshua Cranmer [:jcranmer]]

xzoli, can you post the message as an attachment?

Comment 2

[xzoli]

The mail looked like this below.
It seems to me that if I use the

To: "informal address" <RFC mail address>, ...

format and the text is long enough then the problem shows up.

-------- Original Message --------
Subject: 	mail test
Date: 	Mon, 7 Jul 2008 16:56:32 +0200
From: 	...
To: 	"Very very very very very long address 1" <...>, "Very very very very very long address 2" <...>, "Very very very very very long address 3" <...>


multiple adressee test

Comment 3

[Magnus Melin [:mkmelin]]

Also seen in "thunderbird.exe -safe-mode"?
xref bug 366825.

Comment 4

[Onno Ekker [:nONoNonO UTC+1]]

Attachment: No twisty

The twisty disappears when switching between mails and the mail body has a vertical scrollbar... I have two copies of this message in a folder, and when viewing the first message, all looks normal, and after switching to the next message the twisties are removed.
I think this is new to 2.0.0.16, haven't seren this before.

Comment 5

[Onno Ekker [:nONoNonO UTC+1]]

Attachment: Screendump showing attached e-mail without twisties

Comment 6

[Onno Ekker [:nONoNonO UTC+1]]

I'm using Thunderbird 2.0.0.16 (Windows/20080708) (header is also in attachment).
This also happens with switch -safe-mode.
Can't reproduce this on my version of TB3 (3.0a2pre (2008052703)).

Comment 10

[Ben Bucksch (:BenB)]

> This bug was introduced with 2.0.0.14.

Not true. I'm seeing this with 2.0.0.9.
I am told that it does not happen in TB 1.5.

Comment 11

[Ben Bucksch (:BenB)]

Platform: all (seen on Mac PowerPC). It's XUL anyways :)

Comment 12

[Ben Bucksch (:BenB)]

Attachment: Better testcase

Based on comment 4, I modified the testcase to have a longer body (and longer email addresses in To:, too). Only with this modification, I can reliably reproduce the bug.

Reproduction steps:
0. Use TB 2.x
1. Put the attached message in your message store
1.1. Save this attachment
1 [review].2. Select or create an empty folder in TB in Local Folders
1.3. Go to the corresponding file for the folder on disk in your profile  (plain folder name, no .msf or .sdb extension), and copy the attachment into that file.
1.4. Edit the file and insert an "From - foo" before the message.
1.5. Repeat steps 1.1. - 1.4. for the first attachment 332198 [details] as well. (This is necessary.)
1.5. Delete the .msf file.
1.6. (Re)Open the folder in Thunderbird (TB). You may need to do so several times or restart TB to see the new message.
1.7. Put some other, random messages in the same folder.
2. Trigger the bug in the message viewer
2.1. Open the folder with the testcase in TB.
2.2. Click on testcase 1 (-> twisty still shows)
2.3. Click on testcase 2 (-> twisty does not show)
2.4. Click on testcase 1 (-> twisty does not show)
2.5. Click on any other message in same folder (-> twisty shows again)
2.6. You can repeat 2.2. - 2.5.

---

I can NOT reproduce this with Thunderbird 3.x (trunk). TB 3 has a "more" text on the right instead of the twisty, but has also somewhat reworked the code, which is probably the reason for the bug fix.

However, TB3 has ANOTHER bug: If the email addresses on the first line are long, and the message pane/viewer is not very wide, the "more" on the "to:" line is pushed into the area of some other widget (the invisible S/MIME or Junk/Scam icon? the "hide details" button a bit further down?) and again not visible. Once you widen the window, the more gradually appears, first partially cut off, the typical "overflow: hidden" behavior. The same happens with the "more" on the "cc" line - just later, because my testcase has shorter email addresses on the cc than on the to. I.e. the "more" is not in an absolute place, but on the same box as the email addresses, and thus pushed out due to long addresses.

Comment 13

[Ben Bucksch (:BenB)]

I filed bug 489591 for the TB 3.x bug.
This bug here shall now be limited to Thunderbird 2.x branch.

Comment 14

[Ben Bucksch (:BenB)]

Attachment: Fix, version 1

This patch fixes it.
This:
      <xul:hbox class="headerValueBox" anonid="longEmailAddresses" flex="1"
                onoverflow="this.parentNode.toggleIcon.collapsed = false;"
                onunderflow="this.parentNode.toggleIcon.collapsed = true;">
already adds *and removes* the twisty as needed.
this.toggleIcon.collapsed = true;
in clearEmailAddresses brings things in an inconsistent state: The twisty is removed, but if both the previous and new message have many email addresses, the onoverflow does not fire, so the twisty is not added again.
It seems the onoverflow should fire, because clearEmailAddresses also does this.clearChildNodes(this.emailAddresses); , but the latter leaves a "cache" of address nodes (3, specifically), so they are not actually cleared. If these 3 addresses (of the previous mail) are longer than one line, as is the case with many email addresses, the bug hits.
An alternative fix would be to remove the content of the cached email address nodes or to remove the cache.

Comment 15

[Ben Bucksch (:BenB)]

> as is the case with many email addresses

as is the case with long email addresses

Comment 16

[Ben Bucksch (:BenB)]

trunk doesn't have that line (that I removed) either, so this seems to be the right fix.

Comment 17

[Jeff Dwoskin]

I'm observing the same kind of problem in 2.0.0.21. Many messages come in with 5-6 people on the Cc: line. When I open the message in the preview pane, 2 recipients are shown on the Cc: line with a trailing "," but no + button appears to expand the full list. If I collapse and re-expand the headers using the -/+ next to "Subject", then the expand button appears next to Cc until I click another e-mail in my inbox and then come back to this one. 

I can also get the expand button to appear if I shrink the window horizontally until just *past* when the 2nd address shown on the Cc line disappears. If I then widen the window again, the expand button disappears again.

Comment 18

[Ben Bucksch (:BenB)]

There's a minor bug with Fix v1:

Reproduction:
1. Open mail with many recipients, so that the [+] is displayed
2. Click the [+] (to show all recipients)
3. Click on a mail with only one recipient
Actual result:
The line has a superfluous [+]. You can even click it and it turns into a [-], but nothing expands (because there's nothing to expand).
Expected result:
No [+] nor [-] for mails with only one recipient.

The fix for this is difficult. It's because the onoverflow/underflow event doesn't fire after the addresses were expanded. I don't understand the reason entirely.

Comment 19

[Ben Bucksch (:BenB)]

Attachment: Fix, v2, matching TB3 code: Only expand

Fix for the problem described in the last comment.

Given that I didn't entirely understand why onunderflow doesn't fire, I decided to look at the TB3 code, where this whole bug doesn't appear. I noticed that TB3 avoids the latest problem by simply removing the "more" button, i.e. not allowing to collapse again after expanding. You just have to select another mail, and the addresses (of the new mail) will be collapsed again.

This patch makes the TB2 behavior like the TB3 behavior.

Comment 20

[Ben Bucksch (:BenB)]

Comment on attachment 375382 [details] [diff] [review]
Fix, version 1

<dmose> i think it probably doesn't make sense to ship in 2.0
so, removing review request.