443902 - Remove some nsIDocument QIs from txMozillaTextOutput.cpp

Status: RESOLVED FIXED

(Core :: XSLT, defect, P5)

Description

[O. Atsushi (Torisugari)]

Bug 221335 changed the type of |txMozillaTextOutput::mDocument| and |txTransformNotifier::mDocument|
from nsIDOMDocument* to nsIDocument*.

> nsCOMPtr<nsIDocument> mDocument;

http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/content/xslt/src/xslt/txMozillaXMLOutput.h&rev=1.34&mark=86#86

However, mDocument still QI to nsIDocument*.

> nsCOMPtr<nsIDocument> doc = do_QueryInterface(mDocument); 

http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/content/xslt/src/xslt/txMozillaXMLOutput.cpp&rev=1.86&mark=273#273
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/content/xslt/src/xslt/txMozillaXMLOutput.cpp&rev=1.86&mark=804#804
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/content/xslt/src/xslt/txMozillaXMLOutput.cpp&rev=1.86&mark=1111#1111

If I understand right, these are meaningless, while they are harmless as well.

BTW, is it possible to detect such a code systematically?  I mean, for example, editing
QI's macro implementation to check if QI-destination is same as the original type...?

Comment 1

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

You are probably correct. If you attach a patch we can review it and check it in.

Comment 2

[Peter Van der Beken [:peterv]]

Attachment: v1