Closed Bug 444023 Opened 12 years ago Closed 12 years ago

Add JS functions to stop/start callgrind

Categories

(Core :: General, defect)

x86
Linux
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: graydon, Unassigned)

Details

Attachments

(1 file, 1 obsolete file)

Callgrind-specific variant of bug 430423, adds hooks to communicate with a supervisory callgrind monitor from javascript, to start/stop/dump during profiling. Tested on x86-linux only, should work on any callgrind port.

(The dump call accepts a string which you can use to tag separate dumps; this is a specialty of callgrind)
Attachment #328428 - Flags: review?(sayrer)
Comment on attachment 328428 [details] [diff] [review]
patch implementing callgrind supervisor communication

Looks good to me.
Attachment #328428 - Flags: review?(sayrer) → review+
Comment on attachment 328428 [details] [diff] [review]
patch implementing callgrind supervisor communication

r=shaver, thanks!
Attachment #328428 - Flags: review+
Attached patch update to patchSplinter Review
Oops, previous test build only worked on js shell. Typo made browser fail to build. Now confirmed in browser.
Attachment #328428 - Attachment is obsolete: true
Attachment #328439 - Flags: review?(sayrer)
Attachment #328439 - Flags: review?(sayrer) → review+
Committed in revision e00475590236
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.