444101 - FastFindLinksLabel is not translated in he

Status: RESOLVED FIXED

(Mozilla Localizations :: he / Hebrew, defect)

Description

[timeless]

Attachment: picture of FastFindLinksLabel

Build identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9) Gecko/2008052906 Firefox/3.0

Locale pack is from http://releases.mozilla.org/pub/mozilla.org/firefox/releases/3.0/win32/xpi/he.xpi
i have local switcher, noscript and quick locale switcher installed

1. load a web page (dilbert?)
2. press ' <single quote>

expected results:
Hebrew text labeling search field

actual results:
English text

reproducible: only with ', doesn't happen with / (which provides a Hebrew label)

unrelated bugs need to be found for
1. noscript's use of <>s in the script field w/ Hebrew

Comment 1

[Tomer Cohen :tomer]

Thanks for the report, timeless!

Comment 2

[Tomer Cohen :tomer]

Attachment: patch

Comment 3

[Axel Hecht [:Pike]]

Comment on attachment 328511 [details] [diff] [review]
patch

I'm confused to not see a '(' in the translated string.

Comment 4

[Tomer Cohen :tomer]

(In reply to comment #3)
> I'm confused to not see a '(' in the translated string.
Well, It still there. Look right before the colon.

חיפוש מהיר (קישורים בלבד):

Comment 5

[Simon Montagu :smontagu]

Maybe what Axel means is that both '(' and ')' appear as ')' in the diff, but that is just an artefact of viewing the text in left-to-right context. If you set bidi.browser.ui to true and choose "Switch Page Direction" from the view menu or the context menu, the text appears as it will appear in RTL UI.

Comment 6

[Tsahi Asher]

this still exists in 3.5RC2. please commit the patch.

Comment 7

[Tsahi Asher]

somehow i'm sure i saw it in 3.5, but now i don't. maybe i mixed up with 3.0.

Comment 8

[Tomer Cohen :tomer]

(In reply to comment #7)
> somehow i'm sure i saw it in 3.5, but now i don't. maybe i mixed up with 3.0.

I am unable to reproduce. :)

Comment 9

[Tsahi Asher]

well, it's still in 3.0.

Comment 10

[Axel Hecht [:Pike]]

Comment on attachment 328511 [details] [diff] [review]
patch

I can give you approval for .12.

Please use the bugzilla keywords dance and use a rich check-in comment.

Man, I haven't checked the .1 flag for ages and just switched over to a regexp query that actually does catch a request this old.

Comment 11

[Samuel Sidler (old account; do not CC)]

This needs landing in the next 8 hours if it's going to make 1.9.0.12.

Comment 12

[Samuel Sidler (old account; do not CC)]

Comment on attachment 328511 [details] [diff] [review]
patch

This missed 1.9.0.12. Will have to land in 1.9.0.13 when we open up for that.

Comment 13

[Samuel Sidler (old account; do not CC)]

Comment on attachment 328511 [details] [diff] [review]
patch

Gah. Should've approved this earlier...

Re-approving for 1.9.0.14 based on comment 10. Please use the fixed1.9.0.14/verified1.9.0.14 to indicate fixed and verified statuses (after it's verified).

Comment 14

[Axel Hecht [:Pike]]

Tomer, now that you got that award, can you land this on our old cvs tree? ;-)

Comment 15

[Samuel Sidler (old account; do not CC)]

Comment on attachment 328511 [details] [diff] [review]
patch

Moving out approval. You can land this for 1.9.0.15 any time.

Comment 16

[Axel Hecht [:Pike]]

http://bonsai-l10n.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=l10n/he/toolkit/chrome/global&command=DIFF_FRAMESET&file=findbar.properties&rev1=1.5&rev2=1.6&root=/l10n, landed on CVS.