444268 - Text doesn't stay centered when window is made smaller on Mac

Status: RESOLVED WORKSFORME

(Firefox :: Address Bar, defect)

Description

[Mike Kaply [:mkaply]]

In the attached testcase on Mac only, if you resize the window smaller, the text does not stay centered. At some point it simply stops.

This works properly on FF2 Mac, and FF3 Windows.

Seems to be a mac only centering problem.

It should continue to center until the window is very small.

I'm marking this major because this is a layout regression on Mac

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I'm guessing part of the browser chrome doesn't fit in the window anymore either.  If so, this should probably move to Firefox.

Comment 2

[Mike Kaply [:mkaply]]

Yep. If you turn off the navigation toolbar, it works.

The problem starts on Mac at the point the URL bar won't shrink anymore.

Comment 3

[Steven Michaud [:smichaud] (Retired)]

I can confirm that you don't see this bug's symptoms on Windows (in
FF3).

But I do see them (in FF3) on Linux.  So this isn't just an OS X
problem.

Comment 4

[Mike Kaply [:mkaply]]

I believe this is a regression caused by the Awesome bar XUL on some platforms.

Comment 5

[Ed Lee :Mardak]

Both the location bar and search bar toolbar items cause this problem: the center will flex but the curved edges force a minimum width.

The location bar shrinks until the star hits the left curve. The search bar shrinks until the magnifying glass hits its left curve.

Comment 6

[Mike Kaply [:mkaply]]

But that minimum width shouldn't normally affect the content area, should it?

Comment 7

[Shawn Wilsher :sdwilsh]

I agree with comment 6 that the css of places/browser shouldn't affect the content area.  Moving to layout, and hopefully they'll know a better place to put this if it isn't right.

Comment 8

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

It's nothing to do with affecting the inside of the content area.  The problem is that browser.xul and its styles are making the content area the wrong size.  You want to make a content area the same width as the window, but you're making one that's wider.

This bug has happened a whole bunch of times before and I think there's another open duplicate of this as well as a whole bunch of previously-fixed ones.

Next time it's fixed somebody should really write a test.

Comment 9

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Another way to see the problem is that if you load a page that has a vertical scrollbar, when you make the window too narrow, the vertical scrollbar itself will go off the edge of what's visible.

Comment 10

[Mike Kaply [:mkaply]]

this is working much better on FF4