444383 - GCC 4.3.0 - extra "parens" warnings break the build

Status: VERIFIED FIXED

(Tamarin Graveyard :: Build Config, defect)

Description

[Benjamin Smedberg]

Attachment: Disable parens warnings, rev. 1

With GCC 4.3, I get a lot of the following kind of warning-as-error in t-c:

/builds/actionmonkey/src/js/tamarin/core/StringObject.h: In member function ‘avmplus::Atom avmplus::String::getIntAtom() const’:
/builds/actionmonkey/src/js/tamarin/core/StringObject.h:433: error: suggest parentheses around arithmetic in operand of |

I'm happy to add parens in all these cases, but I tend to think that makes the code uglier and would prefer to disable the parenthesis warning class... let me know if you'd instead like the patch to add parens in all the suggested places (several hundred of them).

Comment 1

[Steven Johnson]

For T-C, let's just disable the warning.

If we see similar issues in TT, let's try to correct the code instead... I still want to keep TT as warning-strict as possible.

Comment 2

[Benjamin Smedberg]

Pushed tamarin-central:b8f4900be2b3

I'll open a separate bug if/when I need to deal with TT.

Comment 3

[Chris Peyer]

Resolved fixed engineering / work item that has been pushed.  Setting status to verified.