444387 - Register Button should auto-fill input data on register form

Status: RESOLVED FIXED

(Webtools Graveyard :: Verbatim, defect)

Description

[Dan Schafer [:dschafer]]

Currently, the register link is a button on the login form, but it simply links the user to the register page with all fields blank.  When the user clicks "register", it should auto-fill the username and password fields on the registration form with the data they input.

Comment 1

[Dan Schafer [:dschafer]]

Attachment: Make register button auto-fill registration form

Previously, the register button was its own form that posted nothing to register.html.  Now, it is a button that posts to login.html. Since the islogin POST is now on the login button, hitting register won't do any of the login processing.  Then, the pootle.py page-sorter will see that the register button was pressed (since doregister is now in argdict) and redirect to register.html.  However, now the argdict will contain the data from the login form, so the registration form is auto-filled.

Comment 2

[Wil Clouser [:clouserw]]

Comment on attachment 328771 [details] [diff] [review]
Make register button auto-fill registration form

Doesn't work for me:

1) I click log-in and fill in my new details

2) I click Register

3) I get a larger form with my stuff filled in (woo)

4) I fill my stuff in and click Register

5) I get login.html and it says "Login failed"

Comment 3

[Dan Schafer [:dschafer]]

Attachment: Fix for registration problem in previous patch

A bit of a hack; this simply ensures that the registration form POSTs to register.html, so the fact that clicking "register" leaves the URL as login.html doesn't interfere anymore.

The result of registration here should be the same as before this patch; an error about being unable to send e-mail will occur, as we don't have e-mail set up to send yet.

Comment 4

[Wil Clouser [:clouserw]]

Comment on attachment 328918 [details] [diff] [review]
Fix for registration problem in previous patch

This doesn't work if the password is invalid (e.g. less than 6 characters).  I'm not really worried about it but it would be nice to have a notification on the registration page.  That said, r+

Comment 5

[Dan Schafer [:dschafer]]

This is in revision 7744; marking FIXED.